Skip to content

#1673: log error instead of throwing if installation version already present #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hohwille merged 1 commit into from
Jan 20, 2026
Merged

#1673: log error instead of throwing if installation version already present #1682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 20 additions & 19 deletions cli/src/main/java/com/devonfw/tools/ide/tool/IdeasyCommandlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,27 +181,28 @@ public void installIdeasy(Path cwd) {
Path ideasySoftwarePath = idePath.resolve(IdeContext.FOLDER_SOFTWARE).resolve(MvnRepository.ID).resolve(IdeasyCommandlet.TOOL_NAME)
.resolve(IdeasyCommandlet.TOOL_NAME);
Path ideasyVersionPath = ideasySoftwarePath.resolve(IdeVersion.getVersionString());
FileAccess fileAccess = this.context.getFileAccess();
if (Files.isDirectory(ideasyVersionPath)) {
throw new CliException("IDEasy is already installed at " + ideasyVersionPath + " - if your installation is broken, delete it manually and rerun setup!");
this.context.error("IDEasy is already installed at {} - if your installation is broken, delete it manually and rerun setup!", ideasyVersionPath);
} else {
List<Path> installationArtifacts = new ArrayList<>();
boolean success = true;
success &= addInstallationArtifact(cwd, "bin", true, installationArtifacts);
success &= addInstallationArtifact(cwd, "functions", true, installationArtifacts);
success &= addInstallationArtifact(cwd, "internal", true, installationArtifacts);
success &= addInstallationArtifact(cwd, "system", true, installationArtifacts);
success &= addInstallationArtifact(cwd, "IDEasy.pdf", true, installationArtifacts);
success &= addInstallationArtifact(cwd, "setup", true, installationArtifacts);
success &= addInstallationArtifact(cwd, "setup.bat", false, installationArtifacts);
if (!success) {
throw new CliException("IDEasy release is inconsistent at " + cwd);
}
fileAccess.mkdirs(ideasyVersionPath);
for (Path installationArtifact : installationArtifacts) {
fileAccess.copy(installationArtifact, ideasyVersionPath);
}
this.context.writeVersionFile(IdeVersion.getVersionIdentifier(), ideasyVersionPath);
}
FileAccess fileAccess = this.context.getFileAccess();
List<Path> installationArtifacts = new ArrayList<>();
boolean success = true;
success &= addInstallationArtifact(cwd, "bin", true, installationArtifacts);
success &= addInstallationArtifact(cwd, "functions", true, installationArtifacts);
success &= addInstallationArtifact(cwd, "internal", true, installationArtifacts);
success &= addInstallationArtifact(cwd, "system", true, installationArtifacts);
success &= addInstallationArtifact(cwd, "IDEasy.pdf", true, installationArtifacts);
success &= addInstallationArtifact(cwd, "setup", true, installationArtifacts);
success &= addInstallationArtifact(cwd, "setup.bat", false, installationArtifacts);
if (!success) {
throw new CliException("IDEasy release is inconsistent at " + cwd);
}
fileAccess.mkdirs(ideasyVersionPath);
for (Path installationArtifact : installationArtifacts) {
fileAccess.copy(installationArtifact, ideasyVersionPath);
}
this.context.writeVersionFile(IdeVersion.getVersionIdentifier(), ideasyVersionPath);
fileAccess.symlink(ideasyVersionPath, installationPath);
addToShellRc(BASHRC, ideRoot, null);
addToShellRc(ZSHRC, ideRoot, "autoload -U +X bashcompinit && bashcompinit");
Expand Down