Skip to content

Conversation

@hohwille
Copy link
Member

@hohwille hohwille commented Jan 20, 2026

This PR fixes #1679

Implemented changes:

  • added test to prove bug
  • fixed bug

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@hohwille hohwille added this to the release:2026.01.001 milestone Jan 20, 2026
@hohwille hohwille added npm node package manager ng Angular CLI yarn package manager alternative to npm bugfix PR that fixes a bug issue labels Jan 20, 2026
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Jan 20, 2026
@hohwille hohwille moved this from 🆕 New to 👀 In review in IDEasy board Jan 20, 2026
@hohwille hohwille self-assigned this Jan 20, 2026
@hohwille hohwille merged commit 365b39a into devonfw:main Jan 20, 2026
2 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDEasy board Jan 20, 2026
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 21171004651

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 70.471%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 78.33%
Totals Coverage Status
Change from base Build 21132142871: 0.09%
Covered Lines: 10469
Relevant Lines: 14269

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue ng Angular CLI npm node package manager yarn package manager alternative to npm

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Npm based commandlets fail to determine installed version of npm tool

2 participants