Fixes code examples causing failing doctest.#29
Open
darrenklein wants to merge 1 commit intodevonestes:masterfrom
Open
Fixes code examples causing failing doctest.#29darrenklein wants to merge 1 commit intodevonestes:masterfrom
darrenklein wants to merge 1 commit intodevonestes:masterfrom
Conversation
Closed
Author
|
@devonestes just a friendly ping! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@devonestes thank you so much for your hard work on this project! As noted in #27, there are some failing doctests. This is simply because the :user object referred to in the code examples in the documentation was not included in the test schema data, and the result data had a few additional fields that needed to be accounted for (like
__typename). I believe that this PR will resolve those failing doctests, and I think should fix the failing build (can't guarantee that second part).Hope this is helpful, please let me know if there's anything you'd like handled differently!