Temporarily remove compilation check for Absinthe#24
Open
timgremore wants to merge 1 commit intodevonestes:masterfrom
Open
Temporarily remove compilation check for Absinthe#24timgremore wants to merge 1 commit intodevonestes:masterfrom
timgremore wants to merge 1 commit intodevonestes:masterfrom
Conversation
Assertions conditionally adds helpers for use with Absinthe. `Assertions.Absinthe` utilizes `Code.ensure_compiled/1` to manage this condition. However, `undefined function assert_response_equals/4` is raised when compiling the all dependencies. Recompiling assertions after compiling all dependencies satisfies the call to `Code.ensure_compiled/1` and the exception is avoided. This removes the conditional check until a proper solution can be found and since we are using Absinthe.
|
@timgremore you saved me from hell... I've been drying myself nuts around this issue until I came up with your comments. |
|
hi @devonestes can we get this merged in soon? Did you need some help with that? |
|
Heads up, this is still an issue and would be really nice to get merged in. |
|
This is still a problem. I also think the docs make it clear that this is unnecessary: https://hexdocs.pm/elixir/Code.html#module-ensure_compiled-1-and-ensure_compiled-1 It would be useful to get this merged in; otherwise, we are having to maintain a fork. |
|
Any update? @devonestes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assertions conditionally adds helpers for use with Absinthe.
Assertions.AbsintheutilizesCode.ensure_compiled/1to manage thiscondition. However,
undefined function assert_response_equals/4is raisedwhen compiling all dependencies. Recompiling assertions after compiling all
dependencies satisfies the call to
Code.ensure_compiled/1and the exceptionis avoided. This removes the conditional check until a proper solution can be
found and since we are using Absinthe.
Issue is also described #22