Skip to content

Refactor MockHttp to register response builder in DI container #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devlead merged 1 commit into from
Nov 22, 2025
Merged

Refactor MockHttp to register response builder in DI container #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Devlead.Testing.MockHttp/IServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ public static IServiceCollection AddMockHttpClient<T>(
this IServiceCollection services
)
{
services.AddSingleton(Routes<T>.GetResponseBuilder);

static MockHttpClient CreateClient(IServiceProvider provider)
{
var client = new MockHttpClient(Routes<T>.GetResponseBuilder(provider));
var client = new MockHttpClient(provider.GetRequiredService<Func<HttpRequestMessage, HttpResponseMessage>>());
foreach(var service in provider.GetServices<ConfigureHttpClient<T>>())
{
service?.Invoke(client);
Expand All @@ -22,7 +24,7 @@ static MockHttpClient CreateClient(IServiceProvider provider)
}

static MockHttpMessageHandlerFactory CreateHttpMessageHandlerFactory(IServiceProvider provider)
=> new(Routes<T>.GetResponseBuilder(provider));
=> new(provider.GetRequiredService<Func<HttpRequestMessage, HttpResponseMessage>>());

return services
.AddTransient<HttpClient>(provider => provider.GetRequiredService<MockHttpClient>())
Expand Down
Loading