Skip to content

Refactor Routes initialization for thread-safety and performance #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devlead merged 1 commit into from
Nov 21, 2025
Merged

Refactor Routes initialization for thread-safety and performance #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 35 additions & 33 deletions src/Devlead.Testing.MockHttp/Routes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System.Net;
using System.Text.Json.Serialization;
using Microsoft.Extensions.DependencyInjection;
using System.Collections.Concurrent;

namespace Devlead.Testing.MockHttp;

Expand Down Expand Up @@ -77,40 +78,41 @@ static ImmutableArray<Route> GetRoutes()
return _routes ??= ImmutableArray.Create(System.Text.Json.JsonSerializer.Deserialize<Route[]>(Resources<T>.GetString("Routes.json") ?? throw new ArgumentNullException("routesJson")) ?? throw new ArgumentNullException("routes"));
}
}
var routes = GetRoutes();


var enableRoute = routes
.Aggregate(
new Dictionary<(
HttpMethod Method,
string AbsoluteUri
),
Action<bool>
>(),
(seed, value) =>
{
void Enable(bool enabled) => value.Request.Disabled = !enabled;
foreach (var method in value.Request.Methods)
{
seed[(method, value.Request.AbsoluteUri)] = Enable;
}

return seed;
},
seed => seed.ToImmutableDictionary()
);
var routes = GetRoutes();

var result =
routes
.Aggregate(
new Dictionary<(
HttpMethod Method,
string AbsoluteUri
),
Func<HttpRequestMessage, HttpResponseMessage>
>(),
(seed, value) =>
(
EnableRoute: routes
.Aggregate(
new ConcurrentDictionary<(
HttpMethod Method,
string AbsoluteUri
),
Action<bool>
>(),
static (seed, value) =>
{
void Enable(bool enabled) => value.Request.Disabled = !enabled;
foreach (var method in value.Request.Methods)
{
seed.TryAdd((method, value.Request.AbsoluteUri), Enable);
}

return seed;
},
seed => seed.ToImmutableDictionary()
),
Routes: new ConcurrentDictionary<(
HttpMethod Method,
string AbsoluteUri
),
Func<HttpRequestMessage, HttpResponseMessage>
>()
),
static (seed, value) =>
{
static HttpResponseMessage AddHeaders(HttpResponseMessage response, Dictionary<string, string[]> headers)
{
Expand Down Expand Up @@ -184,7 +186,7 @@ static HttpResponseMessage AddHeaders(HttpResponseMessage response, Dictionary<s
{
foreach (var enableRequest in response.EnableRequests)
{
if (enableRoute.TryGetValue((enableRequest.Method, enableRequest.AbsoluteUri), out var enable))
if (seed.EnableRoute.TryGetValue((enableRequest.Method, enableRequest.AbsoluteUri), out var enable))
{
enable(true);
}
Expand All @@ -195,7 +197,7 @@ static HttpResponseMessage AddHeaders(HttpResponseMessage response, Dictionary<s
{
foreach (var disableRequest in response.DisableRequests)
{
if (enableRoute.TryGetValue((disableRequest.Method, disableRequest.AbsoluteUri), out var enable))
if (seed.EnableRoute.TryGetValue((disableRequest.Method, disableRequest.AbsoluteUri), out var enable))
{
enable(false);
}
Expand All @@ -214,12 +216,12 @@ static HttpResponseMessage AddHeaders(HttpResponseMessage response, Dictionary<s

foreach (var method in value.Request.Methods)
{
seed[(method, value.Request.AbsoluteUri)] = responseFunc;
seed.Routes.TryAdd((method, value.Request.AbsoluteUri), responseFunc);
}

return seed;
},
seed => seed.ToImmutableDictionary()
static seed => seed.Routes.ToImmutableDictionary()
);

return result;
Expand Down