arch: prevent erroring at init in isolation #2815
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2815 +/- ##
==========================================
+ Coverage 78.78% 83.03% +4.24%
==========================================
Files 248 248
Lines 51074 51072 -2
Branches 4491 4491
==========================================
+ Hits 40239 42407 +2168
+ Misses 10010 7896 -2114
+ Partials 825 769 -56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mloubout
force-pushed
the
patch-init-nocuda
branch
from
6344a03 to
512ff6f
Compare
devito/arch/archinfo.py
Outdated
| # cudart present but no driver detected. Likely isolation | ||
| # run such as version check or within a docker build. | ||
| return | ||
|
|
There was a problem hiding this comment.
Anti-pattern, fixing...
There was a problem hiding this comment.
According to docs only driver can be 0 (NULL is invalid though)
There was a problem hiding this comment.
We should 100% be warning users though, not blind returning from this function
There was a problem hiding this comment.
I can add the warning yes. It's highly unlikely a user works of see it though this merely only happens when you for example check devito.version within a docker build (which won't show the warning )
There was a problem hiding this comment.
Check out my changes and see if you agree
There was a problem hiding this comment.
I thought there were use cases where you might run Devito on a login node without the driver before deploying on a compute node with the driver (in which case warning but not failing seems like a good course of action)
There was a problem hiding this comment.
That's a use case too yes. As of your change I personally prefer the library call and value check in separate statements but that's really not important so can just merge.
FYI was breaking the pro editable install because it was failing to check version during building
JDBetteridge
force-pushed
the
patch-init-nocuda
branch
from
b6e852d to
a3937bb
Compare
mloubout
force-pushed
the
patch-init-nocuda
branch
from
a3937bb to
3bcf92f
Compare
| runtime_version = runtime_version.value | ||
| # Check the get*Version call succeeds and is a non-zero value | ||
| if cuda.cudaDriverGetVersion(ctypes.byref(driver_version)) == 0 \ | ||
| and cuda.cudaRuntimeGetVersion(ctypes.byref(runtime_version)) == 0 \ |
There was a problem hiding this comment.
ultra-nitpick: for homogeneity, the and should go on the line above, and the conditional expression should be aligned to the one above (in this case, it's indented instead)
No description provided.