Add join support and calling functions on functions#1
Merged
devinus merged 12 commits intodevinus:masterfrom Aug 13, 2015
Merged
Add join support and calling functions on functions#1devinus merged 12 commits intodevinus:masterfrom
devinus merged 12 commits intodevinus:masterfrom
Conversation
added 12 commits
September 11, 2014 07:49
devinus
pushed a commit
that referenced
this pull request
Aug 13, 2015
Add join support and calling functions on functions
|
This PR fails with the following test case: {<<"SELECT * FROM outer(var1 := 1, var2 := inner(innervar := 2))">>,
?_safe_test({select,'*',{from,{call,outer,[{var1, 1},{var2,{call,inner,[{innervar, 2}]}}]}}})
} |
This was referenced Nov 11, 2015
Author
|
@ptrf Can you post the stack trace of the failure to gist or somewhere? |
|
@spiegela Here you go: https://gist.github.com/ptrf/b6179a092f17a8d3c5a1 This is from running Do also read the 3 commits and commit messages attached in PR #6 that I submitted to fix this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know it's been a while since this program has been updated, and I'm not sure if it's still in use. I've found it very useful for working with a legacy schema that doesn't fit into other tool requirements. Thanks for making it available!
I've added join support for a project I'm working on.
I've also added the ability to call functions on functions for some weird SQL like: