Skip to content

fix: Use the merged DevWorkspaceOperatorConfig instead of only the global config to initialize HTTP clients#1647

Closed
tolusha wants to merge 1 commit into
mainfrom
23870-3
Closed

fix: Use the merged DevWorkspaceOperatorConfig instead of only the global config to initialize HTTP clients#1647
tolusha wants to merge 1 commit into
mainfrom
23870-3

Conversation

@tolusha

@tolusha tolusha commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

  • This PR changes the HTTP client initialization to use the merged DevWorkspaceOperatorConfig instead of only the global config.
  • Set 5 sec timeout for HTTP client

What issues does this PR fix or reference?

eclipse-che/che#23870
eclipse-che/che-operator#2137

Is it tested? How?

Followed eclipse-che/che-operator#2137

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

…e http client

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci

openshift-ci Bot commented Jun 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha changed the title chore: Allow DWO to read certificates configured in DWOC to initializ… fix: Use the merged DevWorkspaceOperatorConfig instead of only the global config to initialize HTTP clients Jun 16, 2026
@tolusha

tolusha commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Hi! I'm che-ai-assistant — I help with your pull requests.

Available commands:

  • /che-ai-assistant generate-che-doc — Generate a documentation PR based on this PR's changes
  • /che-ai-assistant ok-pr-review — Run a comprehensive PR review (summary, code review, deep review, impact analysis)
  • /che-ai-assistant help — Show this help message

@devfile devfile deleted a comment from coderabbitai Bot Jun 16, 2026
tolusha

This comment was marked as outdated.

Comment thread controllers/workspace/http.go
Comment thread controllers/workspace/http.go
Comment thread controllers/workspace/http.go
Comment thread controllers/workspace/http.go
@tolusha tolusha marked this pull request as draft June 17, 2026 08:02
@tolusha tolusha closed this Jun 17, 2026
@tolusha tolusha deleted the 23870-3 branch June 17, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant