Skip to content

chore (deps) : update controller-runtime to v0.24.1#1642

Open
rohanKanojia wants to merge 2 commits into
devfile:mainfrom
rohankanojia-forks:pr/bump-controller-runtime-0-24-1
Open

chore (deps) : update controller-runtime to v0.24.1#1642
rohanKanojia wants to merge 2 commits into
devfile:mainfrom
rohankanojia-forks:pr/bump-controller-runtime-0-24-1

Conversation

@rohanKanojia

@rohanKanojia rohanKanojia commented Jun 9, 2026

Copy link
Copy Markdown
Member

What does this PR do?

  • Bump sigs.k8s.io/controller-runtime from v0.23.3 to v0.24.1
  • Upgrade aligned Kubernetes dependencies from v0.35.0 to v0.36.0 (k8s.io/api, k8s.io/apimachinery, k8s.io/client-go, etc.)
  • Regenerate CRD and deployment manifests to reflect updated upstream OpenAPI schema descriptions (cosmetic only; no API field changes)

No application code changes were required — the operator compiles cleanly against the new dependencies.

Signed-off-by: Rohan Kumar rohaan@redhat.com

What issues does this PR fix or reference?

N/A — routine dependency maintenance. No linked issue.

Keeps DWO aligned with the supported controller-runtime / client-go version matrix (controller-runtime v0.24.x requires k8s.io/* v0.36). No functional bug fix or feature change.

Is it tested? How?

Tested locally, at the build and unit-test level. I also ran pre-release testing script to test basic deworkspace operator flow.

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Summary by CodeRabbit

  • Documentation

    • Simplified container security context field descriptions by removing feature flag requirement notes.
    • Updated volume mounting behavior documentation to clarify access modes.
  • Chores

    • Updated Go module dependencies to latest patch and minor versions, including Kubernetes and testing framework upgrades.

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohanKanojia
Once this PR has been reviewed and has the lgtm label, please assign dkwon17 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

CRD schema description strings are updated across all generated and template YAML manifests: the ProcMountType feature-flag requirement sentence is removed from procMount fields, the noexec clause is dropped from image volume descriptions, and the CSIMigrationPortworx conditional is removed from portworxVolume descriptions. Separately, go.mod bumps Kubernetes dependencies from v0.35.0 to v0.36.0 and updates several indirect packages.

Changes

CRD Schema Description Updates

Layer / File(s) Summary
CRD template source description changes
deploy/templates/crd/bases/controller.devfile.io_devworkspaceoperatorconfigs.yaml, deploy/templates/crd/bases/controller.devfile.io_devworkspaceroutings.yaml
Removes the ProcMountType feature-flag requirement sentence from procMount fields and drops noexec/CSIMigrationPortworx text from volume descriptions in the template CRD bases.
Generated manifest description changes
deploy/bundle/manifests/controller.devfile.io_devworkspace*.yaml, deploy/deployment/kubernetes/combined.yaml, deploy/deployment/kubernetes/objects/*.yaml, deploy/deployment/openshift/combined.yaml, deploy/deployment/openshift/objects/*.yaml
Propagates the same description text removals to all generated bundle manifests, per-object CRD YAMLs, and combined deployment YAMLs for Kubernetes and OpenShift targets.

Go Dependency Bumps

Layer / File(s) Summary
go.mod dependency version upgrades
go.mod
Bumps k8s.io/* from v0.35.0 to v0.36.0, advances sigs.k8s.io/controller-runtime, updates ginkgo/gomega, switches cenkalti/backoff from v4 to v5, and upgrades OpenTelemetry, Prometheus, and other indirect dependencies.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • ibuziuk
  • akurinnoy
  • tolusha
  • dkwon17

Poem

🐰 A rabbit tidied up the docs with care,
Snipped out old flags that lingered there.
No more "ProcMountType" cluttering the page,
No noexec myths from a bygone age.
Kubernetes bumped up, nice and clean —
The neatest CRD schemas you've ever seen! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the primary change: upgrading controller-runtime to v0.24.1 and related Kubernetes dependencies, which is the core objective of this dependency update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tolusha

tolusha commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Hi! I'm che-ai-assistant — I help with your pull requests.

Available commands:

  • /che-ai-assistant generate-che-doc — Generate a documentation PR based on this PR's changes
  • /che-ai-assistant ok-pr-review — Run a comprehensive PR review (summary, code review, deep review, impact analysis)
  • /che-ai-assistant help — Show this help message

@rohanKanojia

Copy link
Copy Markdown
Member Author

/ok-to-test

@rohanKanojia rohanKanojia force-pushed the pr/bump-controller-runtime-0-24-1 branch from a4c621f to 784124e Compare June 15, 2026 10:59
@rohanKanojia

rohanKanojia commented Jun 17, 2026

Copy link
Copy Markdown
Member Author

/che-ai-assistant ok-pr-review

Review is complete. Please check the review comments below.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…de to v0.24.1

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia force-pushed the pr/bump-controller-runtime-0-24-1 branch from 784124e to 06db064 Compare June 17, 2026 11:11
@rohanKanojia rohanKanojia marked this pull request as ready for review June 17, 2026 11:11

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
go.mod (1)

34-132: ⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

E2E tests are pending—critical for validating indirect dependency chain.

The indirect dependency block (lines 34–132) contains numerous version bumps across OpenTelemetry, Prometheus, gRPC, and Kubernetes internal packages. Many of these are coordinated updates driven by the k8s.io/* upgrade. However, the PR objectives explicitly state:

"The PR is marked as work-in-progress with E2E tests pending; reviewers are expected to trigger E2E test suites once the PR is ready for final review."

This means the comprehensive integration test suite (v8-devworkspace-operator-e2e and v8-che-happy-path) has not yet validated these changes end-to-end. Unit tests and local builds passed, but runtime behavior under realistic load, webhook interactions, and CRD reconciliation have not been tested with the new dependencies.

Recommendation: Do not merge until E2E test results confirm all operator flows work correctly with the upgraded dependency chain.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` around lines 34 - 132, The indirect dependency block contains
significant version bumps across OpenTelemetry, Prometheus, gRPC, and Kubernetes
packages that have not been validated through comprehensive E2E testing. Before
merging this PR, trigger the complete E2E test suites
(v8-devworkspace-operator-e2e and v8-che-happy-path) to validate that all
operator flows work correctly with the upgraded dependency chain, including
webhook interactions and CRD reconciliation under realistic load conditions.
Mark the PR as ready for final review only after E2E test results confirm no
regressions have been introduced by these coordinated dependency updates.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@go.mod`:
- Around line 34-132: The indirect dependency block contains significant version
bumps across OpenTelemetry, Prometheus, gRPC, and Kubernetes packages that have
not been validated through comprehensive E2E testing. Before merging this PR,
trigger the complete E2E test suites (v8-devworkspace-operator-e2e and
v8-che-happy-path) to validate that all operator flows work correctly with the
upgraded dependency chain, including webhook interactions and CRD reconciliation
under realistic load conditions. Mark the PR as ready for final review only
after E2E test results confirm no regressions have been introduced by these
coordinated dependency updates.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 921420d9-4db0-4afb-8e51-56a774632072

📥 Commits

Reviewing files that changed from the base of the PR and between 32c3d0a and 06db064.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (11)
  • deploy/bundle/manifests/controller.devfile.io_devworkspaceoperatorconfigs.yaml
  • deploy/bundle/manifests/controller.devfile.io_devworkspaceroutings.yaml
  • deploy/deployment/kubernetes/combined.yaml
  • deploy/deployment/kubernetes/objects/devworkspaceoperatorconfigs.controller.devfile.io.CustomResourceDefinition.yaml
  • deploy/deployment/kubernetes/objects/devworkspaceroutings.controller.devfile.io.CustomResourceDefinition.yaml
  • deploy/deployment/openshift/combined.yaml
  • deploy/deployment/openshift/objects/devworkspaceoperatorconfigs.controller.devfile.io.CustomResourceDefinition.yaml
  • deploy/deployment/openshift/objects/devworkspaceroutings.controller.devfile.io.CustomResourceDefinition.yaml
  • deploy/templates/crd/bases/controller.devfile.io_devworkspaceoperatorconfigs.yaml
  • deploy/templates/crd/bases/controller.devfile.io_devworkspaceroutings.yaml
  • go.mod
💤 Files with no reviewable changes (4)
  • deploy/bundle/manifests/controller.devfile.io_devworkspaceoperatorconfigs.yaml
  • deploy/deployment/kubernetes/objects/devworkspaceoperatorconfigs.controller.devfile.io.CustomResourceDefinition.yaml
  • deploy/templates/crd/bases/controller.devfile.io_devworkspaceoperatorconfigs.yaml
  • deploy/deployment/openshift/objects/devworkspaceoperatorconfigs.controller.devfile.io.CustomResourceDefinition.yaml

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.83%. Comparing base (17aefae) to head (06db064).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
+ Coverage   37.17%   37.83%   +0.65%     
==========================================
  Files         168      168              
  Lines       14761    14769       +8     
==========================================
+ Hits         5488     5588     +100     
+ Misses       8921     8816     -105     
- Partials      352      365      +13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants