chore (deps) : update controller-runtime to v0.24.1#1642
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rohanKanojia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughCRD schema description strings are updated across all generated and template YAML manifests: the ChangesCRD Schema Description Updates
Go Dependency Bumps
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi! I'm che-ai-assistant — I help with your pull requests. Available commands:
|
|
/ok-to-test |
a4c621f to
784124e
Compare
|
/che-ai-assistant ok-pr-review Review is complete. Please check the review comments below. |
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…de to v0.24.1 Signed-off-by: Rohan Kumar <rohaan@redhat.com>
784124e to
06db064
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
go.mod (1)
34-132:⚠️ Potential issue | 🟠 Major | 🏗️ Heavy liftE2E tests are pending—critical for validating indirect dependency chain.
The indirect dependency block (lines 34–132) contains numerous version bumps across OpenTelemetry, Prometheus, gRPC, and Kubernetes internal packages. Many of these are coordinated updates driven by the k8s.io/* upgrade. However, the PR objectives explicitly state:
"The PR is marked as work-in-progress with E2E tests pending; reviewers are expected to trigger E2E test suites once the PR is ready for final review."
This means the comprehensive integration test suite (
v8-devworkspace-operator-e2eandv8-che-happy-path) has not yet validated these changes end-to-end. Unit tests and local builds passed, but runtime behavior under realistic load, webhook interactions, and CRD reconciliation have not been tested with the new dependencies.Recommendation: Do not merge until E2E test results confirm all operator flows work correctly with the upgraded dependency chain.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` around lines 34 - 132, The indirect dependency block contains significant version bumps across OpenTelemetry, Prometheus, gRPC, and Kubernetes packages that have not been validated through comprehensive E2E testing. Before merging this PR, trigger the complete E2E test suites (v8-devworkspace-operator-e2e and v8-che-happy-path) to validate that all operator flows work correctly with the upgraded dependency chain, including webhook interactions and CRD reconciliation under realistic load conditions. Mark the PR as ready for final review only after E2E test results confirm no regressions have been introduced by these coordinated dependency updates.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@go.mod`:
- Around line 34-132: The indirect dependency block contains significant version
bumps across OpenTelemetry, Prometheus, gRPC, and Kubernetes packages that have
not been validated through comprehensive E2E testing. Before merging this PR,
trigger the complete E2E test suites (v8-devworkspace-operator-e2e and
v8-che-happy-path) to validate that all operator flows work correctly with the
upgraded dependency chain, including webhook interactions and CRD reconciliation
under realistic load conditions. Mark the PR as ready for final review only
after E2E test results confirm no regressions have been introduced by these
coordinated dependency updates.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 921420d9-4db0-4afb-8e51-56a774632072
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (11)
deploy/bundle/manifests/controller.devfile.io_devworkspaceoperatorconfigs.yamldeploy/bundle/manifests/controller.devfile.io_devworkspaceroutings.yamldeploy/deployment/kubernetes/combined.yamldeploy/deployment/kubernetes/objects/devworkspaceoperatorconfigs.controller.devfile.io.CustomResourceDefinition.yamldeploy/deployment/kubernetes/objects/devworkspaceroutings.controller.devfile.io.CustomResourceDefinition.yamldeploy/deployment/openshift/combined.yamldeploy/deployment/openshift/objects/devworkspaceoperatorconfigs.controller.devfile.io.CustomResourceDefinition.yamldeploy/deployment/openshift/objects/devworkspaceroutings.controller.devfile.io.CustomResourceDefinition.yamldeploy/templates/crd/bases/controller.devfile.io_devworkspaceoperatorconfigs.yamldeploy/templates/crd/bases/controller.devfile.io_devworkspaceroutings.yamlgo.mod
💤 Files with no reviewable changes (4)
- deploy/bundle/manifests/controller.devfile.io_devworkspaceoperatorconfigs.yaml
- deploy/deployment/kubernetes/objects/devworkspaceoperatorconfigs.controller.devfile.io.CustomResourceDefinition.yaml
- deploy/templates/crd/bases/controller.devfile.io_devworkspaceoperatorconfigs.yaml
- deploy/deployment/openshift/objects/devworkspaceoperatorconfigs.controller.devfile.io.CustomResourceDefinition.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1642 +/- ##
==========================================
+ Coverage 37.17% 37.83% +0.65%
==========================================
Files 168 168
Lines 14761 14769 +8
==========================================
+ Hits 5488 5588 +100
+ Misses 8921 8816 -105
- Partials 352 365 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What does this PR do?
sigs.k8s.io/controller-runtimefrom v0.23.3 to v0.24.1k8s.io/api,k8s.io/apimachinery,k8s.io/client-go, etc.)No application code changes were required — the operator compiles cleanly against the new dependencies.
Signed-off-by: Rohan Kumar rohaan@redhat.com
What issues does this PR fix or reference?
N/A — routine dependency maintenance. No linked issue.
Keeps DWO aligned with the supported controller-runtime / client-go version matrix (controller-runtime v0.24.x requires k8s.io/* v0.36). No functional bug fix or feature change.
Is it tested? How?
Tested locally, at the build and unit-test level. I also ran pre-release testing script to test basic deworkspace operator flow.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with CheSummary by CodeRabbit
Documentation
Chores