chore (deps) : update controller-runtime to v0.23.1#1568
chore (deps) : update controller-runtime to v0.23.1#1568rohanKanojia wants to merge 3 commits intodevfile:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rohanKanojia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/retest |
a4264d3 to
63ba147
Compare
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…de to v0.23.1 Signed-off-by: Rohan Kumar <rohaan@redhat.com>
This method arguments were changed in controller-runtime v0.23.0.
Existing code of the form builder.WebhookManagedBy(mgr).For(&corev1.Deployment{}) has to be changed to builder.WebhookManagedBy(mgr, &appsv1.Deployment{})
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
7f50c28 to
c5cca66
Compare
|
@rohanKanojia: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What does this PR do?
This PR updates
sigs.k8s.io/controller-runtimefrom v0.22.1 to v0.23.1, along with corresponding Kubernetes API dependencies tov0.35.0. This is a routine dependency update to ensure the DevWorkspace Operator stays current with the latest stable controller-runtime releases.What issues does this PR fix or reference?
N/A - This is a routine dependency update for maintenance purposes.
Is it tested? How?
go.modandgo.sumfiles with dependency version changesbuilder.WebhookManagedBy(mgr).For(&corev1.Deployment{})has to be changed tobuilder.WebhookManagedBy(mgr, &appsv1.Deployment{})PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che