Revamp shading

[devendrn]

All changes made to this branch will be for testing, and will include redundant code and comments.

Changes in mind for this PR:

• New sky model
• Update lighting
• Improve clouds
• Improve fog

Please report any issue with these changes. Feedback will really help.

New Sky

Features

• Custom sun/moon rotation (yaw, tilt) . Also removes in-game sun/moon scaling effect when looking at it.
• 2d sky based on sun/moon direction (old one was 1d, with extra overlay effects)
• New cube sun texture (based on current moon texture)
• Rainbow positioning based on sun direction (also rainbow is now enabled by default during rain). Reduced rainbow width also.
• Sun/moon light present in sky reflections and fog now (TODO: Make this a brighter for reflection and dimmer for fog?)

Known issues:

• Moon abtruptly changing position right after midnight (FIXED)
• Disabled underwater streak. need to update it (TOFIX)
• Sun/Moon flickering near sunrise/sunset (FIXED)
• Dark blob artifact at sun/moon center in some devices (FIXED)

Updated Lighting

Features

• New lighting logic (also moved all lighting logic to vertex shader itself). No more hacky torchlight dimming in sunlight region. Now it blends properly with sun light.
• Improved day/night transition using sun direction
• Improved dawn lighting. Slight sunlight gradient fade during sunrise.
• Correct cloud shadow projection (also enabled cloud shadow on terrain by default)

Known issues:

• Need to update actor,items shading to match terrain (TODO)
• Need to update underwater lighting (TODO)

Update clouds

Features

• Move clouds with minecraft world position (for rounded, realistic)
• Cloud reflection now matches correctly with actual cloud plane and is now present for terrain reflection aswell.
• Improve clouds lighting (TODO)

Other changes

Features

• Improve water and lava noise (TODO)

[xLynxiummcx]

🔥🔥🔥

[devendrn]

Can someone test sun moon rotation for windows?

[BatmanBinSuparman49]

ok

[BatmanBinSuparman49]

Sun/moon rotation in Windows | Minecraft - 1.21.114
@devendrn
https://streamable.com/th7wqb

[faizul726]

Batman saves the day 🗣️🔥🔥

[devendrn]

Can someone test simple, rounded, and realistic clouds movement on windows? It should change with camera position.

[faizul726]

Can someone test simple, rounded, and realistic clouds movement on windows? It should change with camera position.

doing a little bit later @devendrn

[BatmanBinSuparman49]

Clouds 3:
https://streamable.com/kn6fle

Clouds 2:
https://streamable.com/w121kn

Clouds 1:
https://streamable.com/wtn1bx

@devendrn

[faizul726]

doing a little bit later @devendrn

Batman saves the day again

[BatmanBinSuparman49]

doing a little bit later @devendrn

Batman saves the day again

Windows User

[faizul726]

@devendrn build pack -p windows fails

default Clouds was successful

[devendrn]

@faizul726 try again. I made a typo previously.

[faizul726]

@devendrn there's an animated artifact on the sun

see

bandicam.2025-10-28.00-36-38-556.mp4

bandicam.2025-10-28.00-38-16-128.mp4

also, the sun side during rain is a little too bright

[devendrn]

@faizul726 when you are free later, check if that sun artifact happens with fully transparent sun texture.

[faizul726]

happens with fully transparent image also

and moon is also affected by this issue

@devendrn

[BatmanBinSuparman49]

It's doesn't happen to me
@faizul726
It could be a GPU issue
@devendrn

Also Fazul, send that transparent sun.png and let me try

[BatmanBinSuparman49]

Sky is too bright when looking at the side of the sun during rain

[devendrn]

@faizul726 does this artifact happen when you set mg8 to 0.0?

# src/newb/functions/sky.h
-  float mg8 = (g8.x+g8.y)*mask*(1.0-0.9*env.rainFactor);
+  float mg8 = 0.0;

[faizul726]

@devendrn it's 12 am here right now. i will try to test in morning.

also i am updating minecraft to v1.21.120 (which broke materials again)

so you may want to update the material source once again.

[faizul726]

still happens @devendrn

[devendrn]

@faizul726 are you sure you applied the change properly?

Try again. If it still shows up, try with this change instead:

# src/newb/functions/sky.h
-  vec2 g = 0.5 - 0.5*vec2(dot(env.sunDir, viewDir), dot(env.moonDir, viewDir));
+  vec2 g = vec2_splat(0.0);

[mcbegamerxx954]

@mcbegamerxx954 This won't work for my lightmap fix involving fract:

    let finder4 = Finder::new(b"65535.0");

Can we add new finder for vec2(256.0, 4096.0) to detect my fix?

Can do

[devendrn]

New lava noise

Old:

[IndeedItzGab]

https://media.discordapp.net/attachments/844591538025791492/1454501946340675757/image0.jpg?ex=695151ff&is=6950007f&hm=34cff15a9469c34c26b14ca11260fe3591bcf21b9a6c3eeb06694b70157103cf&=&format=webp&width=415&height=876

this one looks fine and performance friendly, untested in-game so I don't know if the repetition is noticeable
screenshot by @ amg

[faizul726]

@mcbegamerxx954 This won't work for my lightmap fix involving fract:

    let finder4 = Finder::new(b"65535.0");

Can we add new finder for vec2(256.0, 4096.0) to detect my fix?

This issue is fixed now for MBL2, Draco and MB Loader.
9a51160 in mtbinloader2
04c7266 in mcbe_shader_redirector

@devendrn

[faizul726]

Also I assume the release of v16.50 is unintentional?

[devendrn]

Hi, how are you? I loved the NewB x Legacy Dev 16.50 version, but there was a minor bug in the end. When I was modifying the end lightmap or the horizon fog, it looked like this and didn't turn the dark color I was supposed to; instead, it reverted to the default color of the vanilla Minecraft end. Here are some screenshots of what happened. 1.21.130

@Jesusmendozaxxx What is the bug exactly here? What config options did you change exactly?

[devendrn]

@Jesusmendozaxxx I have created discussion page for these things. You can ask for support there. #61

[faizul726]

@devendrn I am keeping a list of commits that worked on specific versions of Minecraft. (As 1.21.100 - 1.21.130 went pretty rough in context of breaking existing shaders)

So, I want to know, do you remember updating lightmap/code 1.21.111 - v1.21.114 and 1.21.120 - 1.21.124 range? I can't find the relevant commits and I am unable to recall whether .100's lightmap fix worked on those versions.

[faizul726]

Also, some (perhaps many) people don't like the new pinkish sky/sun. You may want to reconsider looks of those.

[devendrn]

This PR is still mostly unfinished but its getting cluttered with many unrelated changes, so I'm merging this to main. Probably will make separate PRs for each sub feature change.