feat: native zero-copy exchange for all Zarr memory layouts#31
Merged
Conversation
DecodedArray type, supporting native zero-copy exchange for all Zarr formats
DecodedArray type, supporting native zero-copy exchange for all Zarr formatsDecodedArray type, supporting native zero-copy exchange for all Zarr memory layouts
DecodedArray type, supporting native zero-copy exchange for all Zarr memory layouts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explored before, such as in #29, we need to think carefully about our data layouts so they can be exchanged to Python with minimal overhead or copying.
This PR takes the approach of designing
DecodedArray, a custom holder forArrayBytesand which implementsFromArrayBytes. This meansDecodedArraycan be used directly as a result type from operations likeArray.retrieve_chunk.The
DecodedArrayis actually an enum over four concrete types (essentially theArrayBytesvariants):These each become Python types that the user can use
isinstanceto determine which they have.Each of these types expose different options for zero copy conversion:
Closes #29