refactor: move things to hooks, add tests #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview ready!
|
Contributor
There was a problem hiding this comment.
Hi @gadomski ! I like the idea of isolating much of this logic so that it can be easily tested and possibly moved out in the future! I reviewed and made a PR instead to this branch on thoughts/suggestions that I had to hopefully speed things up. If you can review and merge if it looks good? and then we can get this merged in? Let me know 🙇🏼♀️ .
I've described the changes i've made in my PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used Claude to help move some logic into hooks and utility functions, and add some unit tests. @sandrahoang686 this might help identify bits that could be pulled down to stac-react?
Checklist
yarn format)yarn lint)yarn build)yarn test)