fix: overture-geoparquet example#1163
fix: overture-geoparquet example#1163matyasrada wants to merge 3 commits intodevelopmentseed:mainfrom
Conversation
kylebarron
left a comment
kylebarron
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just a couple comments
examples/overture-geoparquet.ipynb
Outdated
| ")" | ||
| ")\n", | ||
| "\n", | ||
| "result = obs.list_with_delimiter(store, prefix=\"release\")\n", |
There was a problem hiding this comment.
Could you use store.list_with_delimiter instead of obs.list_with_delimiter(store, ...)
There was a problem hiding this comment.
Also, can you put this after the commented-out code block that uses the Azure store? Because finding the latest release should be the same for both backends.
examples/overture-geoparquet.ipynb
Outdated
| "We'll create an [S3Store](https://developmentseed.org/obstore/latest/api/store/aws/#obstore.store.S3Store) to access Overture data on AWS S3.\n" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": null, | ||
| "id": "11", | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "store = S3Store.from_url( \n", | ||
| " f\"s3://overturemaps-us-west-2/{latest}/\", \n", | ||
| " region=\"us-west-2\", \n", | ||
| " skip_signature=True, \n", | ||
| " )" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
We don't need to create another store instance. We can just prepend {latest} onto the paths passed below.
|
Hello Kyle! Thanks for the review! I updated a few things:
one problem is that it seems to me Azure doesn't support list_with_delimiter so it can't find the latest release dynamically. i might be wrong. also with this logic if we found it through s3 first as a workaround we still prepended down the cells and so we double-referenced the prefix. |
2 participants
making the release version dynamic by listing the S3 bucket with obstore.list_with_delimiter instead of hardcoding a release date
Closes #1027