Conversation
hrodmn
force-pushed
the
feat/update-20251101
branch
2 times, most recently
from
aebf776 to
8ed7870
Compare
hrodmn
force-pushed
the
feat/update-20251101
branch
from
8ed7870 to
cea188a
Compare
gadomski
requested changes
Nov 5, 2025
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
Looks good, just a couple light notes.
.github/workflows/ci.yml
Outdated
Comment on lines
+51
to
+56
| # This job is commented out and serves as a template for users | ||
| # To use: | ||
| # 1. Create a GitHub environment (Settings > Environments) | ||
| # 2. Configure environment variables in that environment | ||
| # 3. Set up AWS OIDC provider and IAM role with trust relationship to GitHub | ||
| # 4. Uncomment this job and customize as needed |
There was a problem hiding this comment.
The job isn't commented out, so either this doc needs to be updated, or it should be commented.
.github/workflows/ci.yml
Outdated
Comment on lines
+74
to
+75
| with: | ||
| node-version: '22' |
There was a problem hiding this comment.
I generally prefer node-version-file so we have a single point of reference for the node version.
gadomski
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
highlights include: