wip: loaders.gl shim to allow passing input data via data prop#127
Closed
kylebarron wants to merge 1 commit intomainfrom
Closed
wip: loaders.gl shim to allow passing input data via data prop#127kylebarron wants to merge 1 commit intomainfrom
data prop#127kylebarron wants to merge 1 commit intomainfrom
Conversation
Member
Author
|
Would've been interesting but this isn't worth it. It's fine to tell people to pass in props via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally we'd be able to use the
dataprop that most deck.gl layers use. However this doesn't seem possible because the data prop is explicitly tied to loaders.gl and loaders.gl loaders always attempt to load the full input URL.visgl/deck.gl#9931
Closes #131