Skip to content

Quickly access yearly view for given room#220

Open
domi4484 wants to merge 3 commits into
developeregrem:masterfrom
domi4484:overview-room-links
Open

Quickly access yearly view for given room#220
domi4484 wants to merge 3 commits into
developeregrem:masterfrom
domi4484:overview-room-links

Conversation

@domi4484
Copy link
Copy Markdown

Make room numbers hyperlinks in the list overview

Screencast_20260511_054454.webm

@domi4484
Copy link
Copy Markdown
Author

@developeregrem I wanted to say thanks for your great application with a small feature that I am thinking about since some time. I find it useful, but if it doesn't fit in the app filosophy I'll understand 🙂
Disclaimer: I am not a php/symfony programmer, I tried to do my best, but maybe it's not ideal how I did

@developeregrem developeregrem added this to the 4.8.0 milestone May 11, 2026
@developeregrem
Copy link
Copy Markdown
Owner

Wow, that's really good. I can't believe I didn't think of that myself. I find it very useful. I'll take a look at the code later.

this.getLocalTableSetting('holidayCountry', 'reservations-table-holidaycountry');
this.getLocalTableSetting('apartment', 'reservations-apartment', 'int');
// Use stored apartment filter only if not explicitly set in URL
const isExplicitYearlyApartmentLink = /\/view\/yearly\/\d+$/.test(window.location.pathname);
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I would change is to not have a hard coded url path here. If you change the url in ReservationServiceController some will forget this place here probably.
Maybe you can pass a variable to twig in the ReservationServiceController, if direct access is detected and set a data-* attribut on the select element which is checked in the stimulus controller?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants