feat(api): remove _search endpoint and integrate q search support int…#125
Open
pasibun wants to merge 2 commits into
Open
feat(api): remove _search endpoint and integrate q search support int…#125pasibun wants to merge 2 commits into
pasibun wants to merge 2 commits into
Conversation
…o list and filter APIs [deploy-test]
|
✅ Changie-fragment gevonden. |
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the dedicated /v1/apis/_search endpoint and integrates q search support into the existing list (/v1/apis) and filter (/v1/apis/filters) endpoints, updating routing, models, repository filtering, OpenAPI documentation, and tests accordingly.
Changes:
- Removed the
_searchroute/controller/service/repository API surface and corresponding tests. - Added
qquery parameter support to list and filter endpoints (models + repository filtering logic). - Updated OpenAPI spec, integration tests, and changelog to reflect the new API behavior.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/api_client/services/api_service.go | Removes SearchApis service method; list/filter flows rely on unified filtering. |
| pkg/api_client/services/api_service_test.go | Removes SearchApis tests; extends list tests to assert forwarding of q. |
| pkg/api_client/services/api_service_oas_test.go | Updates repository stub to match removed SearchApis interface method. |
| pkg/api_client/routers.go | Removes /apis/_search route; updates descriptions to mention optional q. |
| pkg/api_client/repositories/api_repositorie.go | Removes DB-backed SearchApis; adds q matching into compiled filter matcher. |
| pkg/api_client/repositories/api_repositorie_test.go | Adds coverage asserting filter counts respect q and list filtering accepts it. |
| pkg/api_client/models/list_apis_search_params.go | Deletes now-obsolete search params model used only by _search. |
| pkg/api_client/models/list_apis_params.go | Adds Query (q) and forwards it into ApiFiltersParams. |
| pkg/api_client/models/filter.go | Adds Query (q) to ApiFiltersParams so filters endpoint can apply search term. |
| pkg/api_client/integration_test.go | Updates integration tests to use /v1/apis?q=... instead of /v1/apis/_search. |
| pkg/api_client/handler/api_handler.go | Removes controller handler for /apis/_search; list handler remains. |
| pkg/api_client/handler/api_handler_test.go | Removes _search handler test and unused imports/stubs. |
| api/openapi.json | Removes /apis/_search path; adds reusable Search parameter and references it from list/filter endpoints. |
| .changes/unreleased/Changed-20260512-180509.yaml | Adds changelog entry documenting the endpoint removal and new q support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…erals and add corresponding tests [deploy-test]
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o list and filter APIs [deploy-test]