Skip to content

Add proof of concept for generic mkcamp_command.#25

Open
racke wants to merge 1 commit intodevcamps:masterfrom
racke:topic/generic-mk-camp-command
Open

Add proof of concept for generic mkcamp_command.#25
racke wants to merge 1 commit intodevcamps:masterfrom
racke:topic/generic-mk-camp-command

Conversation

@racke
Copy link
Contributor

@racke racke commented Jun 20, 2015

This by no means a complete implementation. Please tell me if you like this idea.
Our use case in local-config:

after_templates_mkcamp_command:carton install

@jonjensen
Copy link
Member

I like this idea a lot. The only thing I think it needs is to use pushd() instead of chdir(), as we don't want to mess with the global cwd state. Could you make that change?

@racke
Copy link
Contributor Author

racke commented Aug 27, 2015

Sure, it will just take a while.

@jonjensen
Copy link
Member

Stefan, I'd still like to get this merged if you're using a after_templates_mkcamp_command feature. Are you game to use pushd instead?

@racke
Copy link
Contributor Author

racke commented Mar 4, 2016

Sure, that is fine for me.

@jonjensen
Copy link
Member

@racke So ... are you going to contribute a revised patch? I thought that's what you meant when you said "Sure, it will just take a while." before.

@racke
Copy link
Contributor Author

racke commented Mar 4, 2016

Yes, I'm going to contribute a revised patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants