fix: exclude sentinel user from search results and correct stale test expectations#136
Merged
grillinr merged 2 commits intoadd-commentsfrom Mar 6, 2026
Merged
Conversation
Merged
…t expectations Co-authored-by: grillinr <169214325+grillinr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add messages tab and conversation UI
fix: exclude sentinel user from search results and correct stale test expectations
Mar 6, 2026
grillinr
approved these changes
Mar 6, 2026
grillinr
added a commit
that referenced
this pull request
Mar 7, 2026
* wip: add messaging * feat: add messages tab * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: derive WebSocket URL from API_BASE_URL in conversation screen (#130) * Initial plan * fix: use API_BASE_URL for WebSocket URL in conversation screen Co-authored-by: grillinr <169214325+grillinr@users.noreply.github.com> * fix: merge reconnection logic from base branch while keeping API_BASE_URL approach Co-authored-by: elifouts <116454864+elifouts@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: grillinr <169214325+grillinr@users.noreply.github.com> Co-authored-by: elifouts <116454864+elifouts@users.noreply.github.com> Co-authored-by: Eli Fouts <eligfouts@gmail.com> * feat: enhance MessageBubble and MessageComposer components - Added authorLabel prop to MessageBubble for displaying message authors. - Improved styling in MessageBubble for better visual consistency. - Updated MessageComposer to include layout animations for dynamic height adjustments. - Refactored input handling in MessageComposer to optimize performance. - Removed unused terminal animation code from MyHeader component. - Added terminal icon mapping in IconSymbol for better icon management. * fix: safe router navigation encoding and /users/search test coverage (#133) * fix: exclude sentinel user from search results and correct stale test expectations (#136) * Initial plan * fix: exclude deleted_user sentinel from search results and update test expectations Co-authored-by: grillinr <169214325+grillinr@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: grillinr <169214325+grillinr@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Nathan Grilliot <grillinr.mail.uc.edu> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: grillinr <169214325+grillinr@users.noreply.github.com> Co-authored-by: elifouts <116454864+elifouts@users.noreply.github.com> Co-authored-by: Eli Fouts <eligfouts@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
TestAPI/User_Testscases forGET /users/searchwere failing due to a query bug and stale expected values.Changes
SearchUsersquery — addedAND id > 0to exclude thedeleted_usersentinel (id=-1) inserted during test setup, which was leaking into results for any prefix starting with"d"q=devandq=d&count=100expected dev_user1's original bio, but an earlier test in the same sequence (PUT /users/dev_user1) mutates it to"Updated developer bio."before the search cases run; updated expected bodies to match✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.