Skip to content

feat: add ways-of-working skill#21

Merged
devantler merged 16 commits intomainfrom
copilot/add-ways-of-working-skill
May 1, 2026
Merged

feat: add ways-of-working skill#21
devantler merged 16 commits intomainfrom
copilot/add-ways-of-working-skill

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 1, 2026

New in-house skill codifying devantler-tech engineering practices for project setup, CI/CD, and testing strategy.

ways-of-working/SKILL.md

  • Testing — TDD (references obra/superpowers skill), unit/integration via SDK test frameworks, E2E via GitHub Actions workflows, benchmarks via SDK benchmark frameworks
  • Platform engineering — maps the standard build→run→publish loop to ksail: initcreateworkload push (OCI)
  • CI/CD pipeline — two tables covering app/library repos and Kubernetes/platform repos across pull_request, merge_group, push to main, and semver tag events
  • Quality gates — strict linting, security scanning, code quality scanning, no coverage regression, no benchmark regression
  • Design — prefer third-party libraries, follow refactoring.guru, use GitHub Flow
  • Data-driven — benchmark data guides perf work, coverage data guides test additions
  • Reference implementations — links to devantler-tech/ksail and devantler-tech/platform

README.md

  • Added ways-of-working row to the Engineering Practices table

Install:

gh skill install devantler-tech/skills ways-of-working

Copilot AI and others added 2 commits May 1, 2026 17:19
devantler and others added 13 commits May 1, 2026 19:27
The repo description said 'not a publisher' and 'until one is added,
releases are no-ops' — both stale now that ways-of-working is an
in-house skill.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Explains that release.yaml on push-to-main auto-calculates the next
semver from conventional commits and creates the tag + GitHub release,
which in turn triggers CD.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Documents the issue → plan → implement flow, referencing the four
devantler-tech/.github issue templates (Feature, Bug, Chore, Kata).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…inciples

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Every change is validated hands-on before merging, with focus on UX
presentation and ensuring all feedback is actionable.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The intro said 'plan → implement → review' but the numbered steps are
issue → plan → implement → test. Updated to match.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Code review is optional — CI's strict gates are the primary feedback
loop. Description updated to cover agent-first workflow, issue filing,
planning, and debugging so agents activate the skill for those tasks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
One ci.yaml + one cd.yaml per repo, with local composite actions for
simple steps and TypeScript actions for complex logic (locally testable,
avoids unreadable bash-in-YAML).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…stkube

Split testing into app/library vs platform/kubernetes subsections.
Platform table now explicitly maps linting→unit, ephemeral cluster→integration,
and real cluster→E2E, all using Testkube for test execution.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Rename 'Kubernetes / Platform' heading to 'Platform / Kubernetes'
  to match the Testing section.
- Change 'exactly two workflow files' to 'two core workflow files'
  and mention release.yaml as a third file.
- Replace 'System test on a local Docker cluster' with 'Integration
  tests on an ephemeral local cluster' + Testkube to match the
  testing taxonomy.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The testing section lists linting/scanning as the platform equivalent
of unit tests, and the app CI/CD table includes it. The platform table
was inconsistently omitting it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@devantler devantler marked this pull request as ready for review May 1, 2026 18:28
Copilot AI review requested due to automatic review settings May 1, 2026 18:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new in-house ways-of-working skill to codify devantler-tech engineering practices (workflow, testing strategy, CI/CD expectations, and platform practices), and updates the repo index to surface and install it.

Changes:

  • Added ways-of-working/SKILL.md with guidance on development workflow, testing, quality gates, and CI/CD pipelines.
  • Updated README.md to reflect in-house publishing and to include ways-of-working in the Engineering Practices table.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
ways-of-working/SKILL.md Introduces the new in-house “Ways of Working” skill content and guidance.
README.md Updates repo positioning (publisher + pointer list) and adds the new skill to the index.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread ways-of-working/SKILL.md Outdated
Comment thread ways-of-working/SKILL.md
- README: 'Each pointer row' -> 'Each row below is either an in-house
  skill or installs directly from its original upstream'
- SKILL.md: soften merge queue step to handle repos without it configured

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@botantler botantler Bot enabled auto-merge (squash) May 1, 2026 18:57
auto-merge was automatically disabled May 1, 2026 18:58

Repository rule violations found

@devantler devantler closed this May 1, 2026
@devantler devantler reopened this May 1, 2026
@devantler devantler enabled auto-merge (squash) May 1, 2026 19:04
@devantler devantler merged commit 40a82e3 into main May 1, 2026
16 checks passed
@devantler devantler deleted the copilot/add-ways-of-working-skill branch May 1, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants