Skip to content

ci: add aggregated 'CI - Required Checks' job#18

Merged
botantler[bot] merged 2 commits intomainfrom
devantler/aggregate-ci-required-checks
Apr 20, 2026
Merged

ci: add aggregated 'CI - Required Checks' job#18
botantler[bot] merged 2 commits intomainfrom
devantler/aggregate-ci-required-checks

Conversation

@devantler
Copy link
Copy Markdown
Contributor

Summary

Add a terminal aggregation job (CI - Required Checks) to the CI workflow that satisfies the org-wide ruleset requiring a single status check on PRs.

Changes

  • Added required-checks job to .github/workflows/ci.yml
  • The job needs: [ci, auto-commit], transitively covering all 4 existing jobs
  • Uses if: always() so it runs even when auto-commit is skipped (pushes to main, fork PRs)
  • Requires ci to succeed; tolerates auto-commit skip but fails on error

Behavior matrix

Event ci auto-commit CI - Required Checks
PR (same repo) ✅ must pass ✅ must pass or skip ✅ gates on both
PR (fork) ✅ must pass ⏭️ skipped (ok) ✅ gates on ci
Push to main ✅ must pass ⏭️ skipped (ok) ✅ gates on ci

Add a terminal aggregation job to the CI workflow that depends on
all other jobs (ci, auto-commit) and gates on their results. This
satisfies the org-wide ruleset requiring a single 'CI - Required
Checks' status check on PRs.

The job requires 'ci' to succeed, tolerates 'auto-commit' being
skipped (forks, pushes), but fails if it errors.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 20, 2026 17:03
@botantler botantler Bot enabled auto-merge (squash) April 20, 2026 17:04
Comment thread .github/workflows/ci.yml Fixed
Comment thread .github/workflows/ci.yml Fixed
Comment thread .github/workflows/ci.yml Fixed
Comment thread .github/workflows/ci.yml Fixed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a terminal aggregation job (CI - Required Checks) to produce a single required CI status check for org-wide rulesets.

Changes:

  • Introduces a new required-checks job that depends on ci and auto-commit
  • Forces the aggregation job to run via if: always() and validates upstream job results
  • Locks down permissions and audits outbound network calls in the aggregation job

Comment thread .github/workflows/ci.yml Outdated
- Move template expressions to env vars to fix zizmor code injection
  warnings (expressions in run: blocks are injection vectors).
- Switch auto-commit check from blocklist (failure) to allowlist
  (success/skipped) so cancelled state also fails the gate.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@botantler botantler Bot merged commit 232b383 into main Apr 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants