Skip to content

Fixed deploy step #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfreeman422 merged 1 commit into from
Mar 22, 2026
Merged

Fixed deploy step #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ jobs:
docker pull "$IMAGE"

# Tear down the currently running container (if any).
docker stop muzzle 2>/dev/null || true
docker rm muzzle 2>/dev/null || true
docker stop ghcr.io/dev-chat/muzzle:latest 2>/dev/null || true
docker rm ghcr.io/dev-chat/muzzle:latest 2>/dev/null || true
Comment on lines +62 to +63
Copy link

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker stop/docker rm expect a container name/ID, but the workflow now passes an image reference (ghcr.io/dev-chat/muzzle:latest). Since image refs can’t be container names (they include / and :), these commands will be no-ops (stderr is suppressed) and the old container may keep running, causing conflicts when start-muzzle.sh starts the new one. Use a stable container name (e.g. muzzle, matching whatever start-muzzle.sh uses) or resolve the container ID via docker ps (e.g. filter by --filter name=... or --filter ancestor="$IMAGE"). Also avoid hardcoding dev-chat; reuse the existing $IMAGE variable or ${{ github.repository_owner }} for consistency.

Copilot uses AI. Check for mistakes.

# Hand off to your existing startup script which handles volume
# mounts and env var injection.
Expand Down
Loading