Skip to content

add is validated check in mempool fee estimation #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lazynina wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add is validated check in mempool fee estimation #1432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/pos_fee_estimator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ func addBlockToTransactionRegister(txnRegister *TransactionRegister, block *Cach
if txn.Tx.TxnMeta.GetTxnType() == TxnTypeBlockReward {
continue
}

txn.SetValidated(true)
if err := txnRegister.AddTransaction(txn); err != nil {
return errors.Wrap(err,
"PoSFeeEstimator.addBlockToTransactionRegister: error adding txn to pastBlocksTransactionRegister")
Expand Down Expand Up @@ -670,6 +670,10 @@ func (posFeeEstimator *PoSFeeEstimator) estimateFeeRateNanosPerKBGivenTransactio
if !ok {
break
}
// Skip transactions that aren't validated.
if !tx.IsValidated() {
continue
}
totalTxnsSize += tx.TxSizeBytes
txns = append(txns, tx)
if totalTxnsSize > maxSizeOfNumBlocks {
Expand Down