Conversation
Contributor
Author
|
After creating a test implementation of the extract_frame() that supports 2d wavelength array, i realized that since extract_frame returns a desispec.Frame (which only has a 1d wavelength array), so it wouldn't quite make sense to just allow 2d wavelength input for extract_frame. The two alternatives for extract_frame() is
I think 2 is cleaner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial implementation.
First get_spots() is updated to support 2d wavelength arrays. The tests were added to check we get the same results with 2d array as with 1d array.
The next step is to figure out what's the best way to update the extract_frame() interface.