Remove pancake #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # RFC-by-stage/1-approved/remove-pancake.md
elisechant
approved these changes
Dec 13, 2021
Contributor
There was a problem hiding this comment.
Overwhelming yes.
At some stage this may cause package collisions. I see an alternative at that point to change repo from multi-package exports to single-package, but we might entertain that separately (another RFC), the benefit here outweighs any con IMO.
Open
Contributor
|
We might also wrap #16 in to this work, given this:
|
elisechant
reviewed
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal is a bit light on infos as I'm working through all the proposals. I may add more once I have had a deeper look into things