Implement comparison cycling and key deduplication#4
Open
alexankitty wants to merge 4 commits intodescawed:masterfrom
Open
Implement comparison cycling and key deduplication#4alexankitty wants to merge 4 commits intodescawed:masterfrom
alexankitty wants to merge 4 commits intodescawed:masterfrom
Conversation
alexankitty
changed the title
|
Bump! Real good work. Made my own repo with your fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm horrible with rust, just to make that clear.
Anyway, this request aims to add previous/next comparison cycling.
It will read the config file for the last used comparison, and set the start index to there.
It will wrap around either direction, and it will only use the comparisons that are currently enabled.
Caveats:
If the comparison is changed directly in livesplit, it will temporarily desync the cycle until the next change happens in live-split-hotkeys
If the enabled comparisons are changed, they are only written to disk once livesplit is closed, so livesplit and live-split-hotkeys will need to be re-opened.
Bonus:
Also uses a hashset to prevent duplicated keys from being handled. should fix #2