Fix for issue #92 - The element's original transform is discarded#120
Open
Sphinxxxx wants to merge 1 commit intodesandro:masterfrom
Open
Fix for issue #92 - The element's original transform is discarded#120Sphinxxxx wants to merge 1 commit intodesandro:masterfrom
Sphinxxxx wants to merge 1 commit intodesandro:masterfrom
Conversation
…es are discarded
Owner
|
Thanks so much for this contribution! This is nice work. While this issue has gotten some attention, I don't feel there's been enough to warrant adding a fix just yet. I'll keep this PR open so others can chime in. |
|
This would be a great addition. |
|
Ohhh I just opened #156 this morning to address this issue. Please, merge it!!! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically an updated version of pull request #93, but with a fix for rotated elements (see peterbe's comment in issue #92 here: #92 (comment)), and elements with more than one transform property.
Implemented here: http://codepen.io/Sphinxxxx/pen/QyRRom