Skip to content

chore: reconcile production (legacy) with staging (master)#346

Merged
maryia-deriv merged 1 commit into
legacyfrom
maryia/reconcile-legacy-with-staging
Jun 4, 2026
Merged

chore: reconcile production (legacy) with staging (master)#346
maryia-deriv merged 1 commit into
legacyfrom
maryia/reconcile-legacy-with-staging

Conversation

@maryia-deriv
Copy link
Copy Markdown
Collaborator

@maryia-deriv maryia-deriv commented Jun 3, 2026

Summary

Ports selective staging (master) changes down into production (legacy) to bring the two branches to full parity. src/ is already identical; this PR closes the remaining drift. After this PR and #347 merge, master and legacy are byte-for-byte identical.

Changes

A — Security / dependencies

  • .trivyignore: new file with CVE suppressions + justifications (protobufjs entries omitted — fixed at source, see below)
  • package.json: pin dependencies/devDependencies to exact versions (drop caret ranges) using the versions already resolved in production's lock; keep overrides lodash 4.18.0, lodash-es 4.18.0, dompurify 3.4.0; add protobufjs 7.5.6 (fixes CVE-2026-41242 CRITICAL + CVE-2026-44289/44290/44291, pulls @protobufjs/utf8 1.1.1 fixing CVE-2026-44293)
  • package-lock.json: regenerated from production's healthy lock base (npm install --force, peer deps retained). Intentionally does not copy staging's broken lock.

B — Schema files (get_settings/set_settings) adopt master's upstream (raw) formatting. These schemas are auto-generated by an external flow that does not run this repo's prettier config; content is identical between branches (only formatting differed). Matching the upstream raw format on both branches avoids a huge reformatting diff on the next automated schema update.

C — CI workflows

  • coveralls.yml: pin action to v2 SHA
  • release_staging.yml: remove Vercel DR step (cosmetic file-parity only — triggers on master, no production deploy impact)

French i18n

  • i18n/fr/code.json refreshed from authoritative source

Verification

⚠️ Review note: changes production's dependency declarations from caret ranges to exact pins (versions resolve to the same ones production already uses) and adopts the upstream raw schema formatting. Please review before merging.

⚠️ Do not merge until human-approved. legacy is production.

🤖 Generated with Claude Code

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
deriv-api-docs Ready Ready Preview Jun 4, 2026 9:25am

Request Review

@maryia-deriv maryia-deriv changed the title chore: reconcile production (legacy) with staging chore: reconcile production (legacy) with staging (master) Jun 4, 2026
@maryia-deriv maryia-deriv force-pushed the maryia/reconcile-legacy-with-staging branch from b525e7f to 8dba218 Compare June 4, 2026 07:44
maryia-deriv added a commit that referenced this pull request Jun 4, 2026
…ging lock)

master's package-lock.json was out of sync with package.json (npm ci
failed: many packages "Missing from lock file", e.g. @testing-library/dom).
Regenerate a valid lock from the healthy production base:

- pin dependencies/devDependencies to exact versions (drop caret ranges),
  using the versions already resolved in the working lock
- keep the security-override version bumps (lodash 4.18.0, lodash-es
  4.18.0, dompurify 3.4.0) plus existing overrides
- regenerate package-lock.json with peer deps retained

Verified: npm ci passes, full jest suite passes, docusaurus build succeeds.
This package.json + package-lock.json is identical to the companion PR
into legacy (#346), so the two branches become fully identical.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maryia-deriv added a commit that referenced this pull request Jun 4, 2026
…ging lock)

master's package-lock.json was out of sync with package.json (npm ci
failed: many packages "Missing from lock file", e.g. @testing-library/dom).
Regenerate a valid lock from the healthy production base:

- pin dependencies/devDependencies to exact versions (drop caret ranges),
  using the versions already resolved in the working lock
- keep the security-override version bumps (lodash 4.18.0, lodash-es
  4.18.0, dompurify 3.4.0) plus existing overrides
- regenerate package-lock.json with peer deps retained

Verified: npm ci passes, full jest suite passes, docusaurus build succeeds.
This package.json + package-lock.json is identical to the companion PR
into legacy (#346), so the two branches become fully identical.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@maryia-deriv maryia-deriv force-pushed the maryia/reconcile-legacy-with-staging branch from 8dba218 to f7a4a41 Compare June 4, 2026 08:09
@maryia-deriv maryia-deriv force-pushed the maryia/reconcile-legacy-with-staging branch from f7a4a41 to 9d34858 Compare June 4, 2026 08:49
@maryia-deriv maryia-deriv force-pushed the maryia/reconcile-legacy-with-staging branch from 9d34858 to d5d3416 Compare June 4, 2026 09:05
Port selective staging changes down into production to bring the two
branches toward full parity. src/ application code is already identical;
this commit closes the remaining drift.

A — Security:
- package.json / package-lock.json: add lodash, lodash-es, dompurify
  overrides; net lock-file cleanup
- .trivyignore: new file with CVE suppressions + justifications

B — Schema refresh (get/set_settings only):
- config/v3/get_settings/receive.json
- config/v3/set_settings/send.json
- config/v3/set_settings/example.json

C — CI workflows:
- .github/workflows/coveralls.yml: pin action to v2 SHA
- .github/workflows/release_staging.yml: remove Vercel DR step

French i18n:
- i18n/fr/code.json refreshed from authoritative source
  (navbar.json already matched, no change)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@maryia-deriv maryia-deriv merged commit 84098c9 into legacy Jun 4, 2026
2 checks passed
@maryia-deriv maryia-deriv deleted the maryia/reconcile-legacy-with-staging branch June 4, 2026 10:22
@maryia-deriv maryia-deriv deployed to Production June 4, 2026 10:22 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants