Skip to content

Show what's being rolled back in the rollback confirmation #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acoshift merged 3 commits into from
Jun 11, 2026
Merged

Show what's being rolled back in the rollback confirmation #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97eba1e
Show what's being rolled back in the rollback confirmation
acoshift Jun 11, 2026
cd73a5f
Match rollback note to actual apiserver semantics
acoshift Jun 11, 2026
bd5968b
Widen rollback modal and show the configuration diff
acoshift Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 26 additions & 7 deletions src/lib/server/mock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,18 +759,37 @@ const handlers = {
'location.get': (args) => ok(locations.find((l) => l.id === args?.location) ?? locations[0]),

'deployment.list': () => list(deployments),
'deployment.get': (args) => ok({ ...deployment(args?.project), name: args?.name ?? 'web', location: args?.location ?? LOCATION_ID }),
// revision > 0 returns that revision's historical spec (like the real
// deployment.get), with per-revision differences so the rollback modal's
// config diff has something to show.
'deployment.get': (args) => {
const base = { ...deployment(args?.project), name: args?.name ?? 'web', location: args?.location ?? LOCATION_ID }
const revision = Number(args?.revision ?? 0)
if (!revision || revision >= base.revision) return ok(base)
return ok({
...base,
revision,
image: base.image.replace(/:latest$/, `:v${revision}`),
env: { NODE_ENV: 'production', PORT: '8080', LOG_LEVEL: 'debug', FEATURE_FLAGS: 'beta-checkout' },
maxReplicas: 2,
command: revision === 5 ? ['node', 'server.js'] : base.command
})
},
'deployment.deploy': () => ok({}),
'deployment.delete': () => ok({}),
'deployment.pause': () => ok({}),
'deployment.resume': () => ok({}),
'deployment.rollback': () => ok({}),
'deployment.revisions': (args) => list([7, 6, 5].map((revision) => ({
...deployment(args?.project),
name: args?.name ?? 'web',
location: args?.location ?? LOCATION_ID,
revision
}))),
'deployment.revisions': (args) => list([7, 6, 5].map((revision) => {
const base = deployment(args?.project)
return {
...base,
name: args?.name ?? 'web',
location: args?.location ?? LOCATION_ID,
revision,
image: revision === base.revision ? base.image : base.image.replace(/:latest$/, `:v${revision}`)
}
})),
'deployment.metrics': () => ok({
cpuUsage: metricLine('web', 0.3),
cpuLimit: metricLine('limit', 0.5),
Expand Down
Loading