Add waf.limitMetrics read API#42
Merged
Merged
Conversation
Mirrors waf.metrics at the (limit, result) grain over ratelimit_usages, so the console can chart the limited share — limited / (allowed + limited) — which is how a shadow-mode limit is sized before enforcing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
waf.limitMetricsread API: request/response types (WAFLimitMetrics,WAFLimitMetricsResult,WAFLimitMetricsSeries) + client method, mirroringwaf.metricsat the(limit, result)grain over the rate-limit usage the collector now stores.The console firewall metrics page (deploys-app/console#187) charts the limited share —
limited / (allowed + limited)— from this, which is how a shadow-mode limit is sized before enforcing.Context
This was originally written on the
ratelimit-usagebranch but landed after api#41 was already squash-merged, so it never made it to main. This re-lands it as a clean single-commit addition on top of #41.Companion: apiserver PR adds the
LimitMetricshandler.🤖 Generated with Claude Code