Skip to content

Change Node.js version to use current LTS in provision script by default #4162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonmedv merged 1 commit into from
Feb 4, 2026
Merged

Change Node.js version to use current LTS in provision script by default #4162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion recipe/provision/nodejs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use function Deployer\Support\escape_shell_argument;

set('node_version', '23.x');
set('node_version', '--lts');
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change updates the default for node_version, but the generated docs are now stale. docs/recipe/provision/nodejs.md still shows the default value as '23.x' (see around its "Default value" block). Please regenerate docs (php bin/docgen) and include the updated docs in this PR.

Suggested change
set('node_version', '--lts');
set('node_version', '23.x');

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaulting to --lts makes provisioning time-dependent (the installed Node version will change when the LTS line advances), which can reduce reproducibility and introduce unexpected changes on reprovisioning. Consider defaulting to an explicit LTS major (and documenting --lts as an opt-in override) if deterministic builds/environments are important for this recipe.

Copilot uses AI. Check for mistakes.

desc('Installs npm packages');
task('provision:node', function () {
Expand Down
Loading