Bump npm version from 10.9.3 to 11.6.2 latest#13482
Merged
thavaahariharangit merged 6 commits intomainfrom Nov 6, 2025
Merged
Conversation
This was referenced Nov 5, 2025
yeikel
reviewed
Nov 5, 2025
| NPM_V8 = "8" | ||
| NPM_V9 = "9" | ||
| NPM_V10 = "10" | ||
| NPM_V11 = "11" |
Contributor
There was a problem hiding this comment.
Can we add a test that validates that this works?
ie:
Using
"engines": {
"npm": ">=11.0.0"
}
Contributor
There was a problem hiding this comment.
@thavaahariharangit Please review github/docs#41144 as well
Contributor
Author
There was a problem hiding this comment.
Can we add a test that validates that this works?
ie:
Using
"engines": { "npm": ">=11.0.0" }
Test added: b846671
Contributor
Author
There was a problem hiding this comment.
@thavaahariharangit Please review github/docs#41144 as well
I have approved this PR, It's a draft PR, we need to wait @yeikel to update this.
Contributor
There was a problem hiding this comment.
Thank you for adding the test 🙏
And yes, as soon as this change is merged, I'll move the docs pull request to ready
Contributor
3 tasks
Contributor
Contributor
Author
|
I am happy with this changes, I will merge and deploy with this changes. |
markhallen
approved these changes
Nov 6, 2025
This was referenced Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
In my previous PR update, I updated the Dockerfile. However, I overlooked some related changes, which I’ve now addressed in this update.
Anything you want to highlight for special attention from reviewers?
I've addressed @yeikel's feedback in this comment.
Regarding the question about Node 22 and NPM 11 compatibility (reference):
How will you know you've accomplished your goal?
I reproduced the original error in this workflow: GitHub Actions run, where the updater defaulted to installing
npm@10.After applying the update, the local logs now show that the correct version
npm@11.6.2is being installed and used, confirming that the engine constraints are being properly processed and the issue is resolved.Checklist