Skip to content

Rename erblint executable to erb_lint since deprecated by Shopify #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nbennke wants to merge 3 commits into
base: master
Choose a base branch
from
+8 −8
Open

Rename erblint executable to erb_lint since deprecated by Shopify #5111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a90f016
Rename erblint executable to erb_lint
nbennke Apr 1, 2026
6c7d17d
Update default erblint executable name
nbennke Apr 1, 2026
d904b3b
Update tests to new excecutable default
nbennke May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ale_linters/eruby/erblint.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
" based on the ale ruumba and robocop linters
" Description: ERB Lint, support for https://github.com/Shopify/erb-lint

call ale#Set('eruby_erblint_executable', 'erblint')
call ale#Set('eruby_erblint_executable', 'erb_lint')
call ale#Set('eruby_erblint_options', '')

function! ale_linters#eruby#erblint#GetCommand(buffer) abort
let l:executable = ale#Var(a:buffer, 'eruby_erblint_executable')

return ale#ruby#EscapeExecutable(l:executable, 'erblint')
return ale#ruby#EscapeExecutable(l:executable, 'erb_lint')
\ . ' --format json '
\ . ale#Var(a:buffer, 'eruby_erblint_options')
\ . ' --stdin %s'
Expand Down
2 changes: 1 addition & 1 deletion doc/ale-eruby.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ erblint *ale-eruby-erblint*
eruby_erblint_executable
g:ale_eruby_erblint_executable
Type: |String|
Default: `'erblint'`
Default: `'erb_lint'`

Override the invoked erblint binary. This is useful for running erblint
from binstubs or a bundle.
Expand Down
10 changes: 5 additions & 5 deletions test/linter/test_erblint.vader
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ Before:
call ale#assert#SetUpLinterTest('eruby', 'erblint')
call ale#test#SetFilename('dummy.html.erb')

let g:ale_eruby_erblint_executable = 'erblint'
let g:ale_eruby_erblint_executable = 'erb_lint'
let g:ale_eruby_erblint_options = ''

After:
call ale#assert#TearDownLinterTest()

Execute(Executable should default to erblint):
AssertLinter 'erblint', ale#Escape('erblint')
Execute(Executable should default to erb_lint):
AssertLinter 'erblint', ale#Escape('erb_lint')
\ . ' --format json --stdin %s'

Execute(Should be able to set a custom executable):
Expand All @@ -18,9 +18,9 @@ Execute(Should be able to set a custom executable):
AssertLinter 'bin/erblint' , ale#Escape('bin/erblint')
\ . ' --format json --stdin %s'

Execute(Setting bundle appends 'exec erblint'):
Execute(Setting bundle appends 'exec erb_lint'):
let g:ale_eruby_erblint_executable = 'path to/bundle'

AssertLinter 'path to/bundle', ale#Escape('path to/bundle')
\ . ' exec erblint'
\ . ' exec erb_lint'
\ . ' --format json --stdin %s'