fix(phpcs): run from project root instead of file directory#5105
Open
Firehed wants to merge 1 commit intodense-analysis:masterfrom
Open
fix(phpcs): run from project root instead of file directory#5105Firehed wants to merge 1 commit intodense-analysis:masterfrom
Firehed wants to merge 1 commit intodense-analysis:masterfrom
Conversation
When phpcs.xml sets installed_paths to a relative path (e.g. vendor/slevomat/coding-standard), running phpcs from the file's directory causes it to fail because the path is resolved relative to cwd rather than the config file location. Change cwd to find the nearest composer.json and use that directory, matching how most PHP ecosystem tools expect to operate. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
phpcs.xmlsetsinstalled_pathsto a relative path (e.g.vendor/slevomat/coding-standard), running phpcs from the file's directory causes it to fail because the path is resolved relative to cwd rather than the config file location.This changes the linter to find the project root by looking for:
phpcs.xml/phpcs.xml.dist/.phpcs.xml/.phpcs.xml.distcomposer.json(fallback)If none are found, it falls back to ALE's default behavior (returns
v:null).This follows the same pattern as the
phpstanlinter.Most likely fixes #3146; I suspect we have the same underlying issue, but that ticket is over 5 years old so I don't want to do too much digging.
Test plan
composer.jsonto test fixture for project root detectioninstalled_pathsset to a relative vendor path🤖 Generated with Claude Code