switch properties visibility to private#6
Open
shevernitskiy wants to merge 1 commit intodenosaurs:mainfrom
Open
switch properties visibility to private#6shevernitskiy wants to merge 1 commit intodenosaurs:mainfrom
shevernitskiy wants to merge 1 commit intodenosaurs:mainfrom
Conversation
Member
|
Sorry for the late reply, any opinion on this @crowlKats? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation for these changes is using emitter as class mixin.
For example, if we use lib ts-mixer for mixing various class traits, it can't copy
#properties.EventEmitter often used as such kind of trait. So, it would be nice to use it directly as dependency without any changes.