Open
Conversation
eliassjogreen
approved these changes
Jul 7, 2022
Member
eliassjogreen
left a comment
eliassjogreen
left a comment
There was a problem hiding this comment.
LGTM, @crowlKats any comments?
Member
|
I dont see much need for this; maybe this should be emit's behaviour? it just seems confusing to have such similar methods |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a method to EventEmitter called
waitthat awaits the completion of each listener. Note: awaiting this method does not work the same way as awaitingemit.