Skip to content

fix: accept no streams in concatReadableStreams#7173

Closed
jrvidal wants to merge 1 commit into
denoland:mainfrom
jrvidal:empty-concat-streams
Closed

fix: accept no streams in concatReadableStreams#7173
jrvidal wants to merge 1 commit into
denoland:mainfrom
jrvidal:empty-concat-streams

Conversation

@jrvidal
Copy link
Copy Markdown

@jrvidal jrvidal commented Jun 4, 2026

I was surprised to find that this case is not contemplated. My gut feeling is that we should return an empty stream.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jrvidal jrvidal closed this Jun 4, 2026
@jrvidal jrvidal deleted the empty-concat-streams branch June 4, 2026 10:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.57%. Comparing base (cdf74a8) to head (e5c2055).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7173      +/-   ##
==========================================
- Coverage   94.57%   94.57%   -0.01%     
==========================================
  Files         636      636              
  Lines       52142    52145       +3     
  Branches     9401     9403       +2     
==========================================
+ Hits        49315    49317       +2     
- Misses       2249     2250       +1     
  Partials      578      578              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants