Update for Thunderbird 68.0

[bit]

No description provided.

[designchris]

Does anyone know what needs to be done to support TB68?

[leres]

I wrote a python script to convert install.rdf files to manifest.json:

[https://github.com/leres/mozilla-install-rdf-to-manifest-json](https://github.com/leres/mozilla-install-rdf-to-manifest-json)

And the manifest.json I've been using for the last few weeks is a little different from the one in pull request #10.

[designchris]

@leres Thanks, I tried to run your script but it's throwing an error:

File "./convert-rdf.py", line 22
print(*args, file=sys.stderr)
^
SyntaxError: invalid syntax

[leres]

@leres Thanks, I tried to run your script but it's throwing an error:

File "./convert-rdf.py", line 22
print(*args, file=sys.stderr)
^
SyntaxError: invalid syntax

I just made a change to add python 2 compatibly, could you please get the new version and try again?

[designchris]

Thank you! At first it failed on Windows, but it works great on Linux!

[htgoebel]

I confirm this pull-request makes tb-correctidentity work on Thunderbird 68.0

[pbonbon]

Plugin doesn't work correctly on Windows 10 using Thunderbird 68.1.1. The configuration cannot be saved.

[peci1]

See bit#1 . I got the fix there and let's hope it will propagate to this PR, too.

[pbonbon]

See bit#1 . I got the fix there and let's hope it will propagate to this PR, too.

It works! Thank you very much!

[bertvandepoel]

@bit I just pulled from your repo and zipped the tb68 branch, then zipped the result. Weirdly, Thunderbird keeps on saying that it's incompatible with 68.4.1. Any guess what I'm doing wrong? Thx :)

[SimonMaenaut]

Sadly the following error appears when I try to install this extension in Thunderbird 68.5.0 on Linux.
addons.xpi WARN Invalid XPI: Error: File /home/simon/Downloads/tb-correctidentity-tb68.zip does not contain a valid manifest(resource://gre/modules/addons/XPIInstall.jsm:671:11) JS Stack trace: loadManifest@XPIInstall.jsm:671:11

[SimonMaenaut]

Zipping the individual elements together instead of a directory with everything inside seems to do the trick :-)

[bertvandepoel]

It seems to install fine with the instructions by @SimonMaenaut but the addon doesn't work for me at that point. I then went on to explore and found that https://github.com/rwg0/tb-correctidentity/tree/tb68 by @rwg0 had a fix for problems with fetching identities (which I seemed to have) and also merged in another fix by @peci1 for saving of settings.
Could you contemplate merging those, @bit , and then adding them to this PR? Hopefully that will convince @dennisverspuij to merge this PR and release on AMO.