Conversation
VadimZharkov
reviewed
Oct 1, 2025
| import java.io.IOException; | ||
| import java.time.Duration; | ||
|
|
||
| public class DurationAdapter extends TypeAdapter<java.time.Duration> { |
There was a problem hiding this comment.
java.time. лишнее, достаточно того что есть секция import java.time.Duration;
VadimZharkov
reviewed
Oct 1, 2025
|
|
||
| protected void sendNotFound(HttpExchange h) throws IOException { | ||
| byte[] resp = "Not Found".getBytes(StandardCharsets.UTF_8); | ||
| h.getResponseHeaders().add("Content-Type", "application/json;charset=utf-8"); |
There was a problem hiding this comment.
Т.к. здесь мы отдаем не json а просто текст, то лучше
("Content-Type", "text/plain")
VadimZharkov
reviewed
Oct 1, 2025
|
|
||
| protected void sendHasOverlaps(HttpExchange h) throws IOException { | ||
| byte[] resp = "Not Acceptable".getBytes(StandardCharsets.UTF_8); | ||
| h.getResponseHeaders().add("Content-Type", "application/json;charset=utf-8"); |
VadimZharkov
suggested changes
Oct 1, 2025
VadimZharkov
left a comment
VadimZharkov
left a comment
There was a problem hiding this comment.
Хорошая работа, в целом все верно. Оставил пару уточнений.
…вки сервера с 200с до 3с.
VadimZharkov
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Реализован функционал согласно ТЗ 9-ого спринта.
Добавлен Http сервер с реализациями обработчиков под разные запросы.
Добавлены тесты для новой функицональности.