Skip to content

Sekoia XDR Pack : Fix small typo#42514

Merged
DeanArbel merged 5 commits intodemisto:contrib/TOUFIKIzakarya_fix/typo_http_commandfrom
TOUFIKIzakarya:fix/typo_http_command
Jan 14, 2026
Merged

Sekoia XDR Pack : Fix small typo#42514
DeanArbel merged 5 commits intodemisto:contrib/TOUFIKIzakarya_fix/typo_http_commandfrom
TOUFIKIzakarya:fix/typo_http_command

Conversation

@TOUFIKIzakarya
Copy link
Copy Markdown
Contributor

@TOUFIKIzakarya TOUFIKIzakarya commented Jan 2, 2026 •
edited by content-bot
Loading

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • [] In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

Fix small typo in the command

Must have

  • [X ] Tests
  • [X ] Documentation

relates: https://jira-dc-proxy.xdr.pan.local/browse/CIAC-15480

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Jan 2, 2026
@content-bot content-bot changed the base branch from master to contrib/TOUFIKIzakarya_fix/typo_http_command January 2, 2026 11:21
@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Jan 2, 2026

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @merit-maita will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Jan 2, 2026

Hi @TOUFIKIzakarya, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Jan 2, 2026
@DeanArbel
Copy link
Copy Markdown
Contributor

DeanArbel commented Jan 4, 2026

@TOUFIKIzakarya this change will break the existing behavior, as the code assumes url_sufix.
In order to keep backward compatibility, please keep the old argument in a deprecated: true mode, while adding the newer suffix to both the yml and the py files - this will support both, while only suggesting the right one henceforth.

DeanArbel
DeanArbel requested changes Jan 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently doesn't support the new url_suffix - please add it to the py file while also adding back the older url_sufix to the yml file with deprecated: true added to it, so it will no longer be suggested in the UI.

@merit-maita merit-maita closed this Jan 4, 2026
@merit-maita merit-maita reopened this Jan 4, 2026
@TOUFIKIzakarya
Copy link
Copy Markdown
Contributor Author

TOUFIKIzakarya commented Jan 5, 2026

Ok thanks, i will push changes today.

@merit-maita merit-maita added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Jan 7, 2026
@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Jan 7, 2026

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Jan 7, 2026

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/6588922

@content-bot content-bot removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Jan 7, 2026
@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Jan 7, 2026

🤖 Content AI Reviewer: Analysis started. Please wait for results...

@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Jan 7, 2026

🤖 Content-bot Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

content-bot
content-bot reviewed Jan 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@content-bot content-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for the contribution!

I just have a couple of minor formatting suggestions for the release notes. Please wrap the command name and arguments in backticks for consistency and ensure the file ends with a newline.

Thanks

@DeanArbel, @merit-maita please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/SekoiaXDR/ReleaseNotes/1_1_11.md

##### Sekoia XDR

- Fixed a typo with the ***sekoia-xdr-http-request*** command where the 'url_suffix' argument was written `url_sufix`, causing an error. No newline at end of file
Copy link
Copy Markdown
Contributor

@content-bot content-bot Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please use backticks for the command name and arguments to ensure consistent styling.
  • Please add a newline at the end of the file.

@TOUFIKIzakarya
Copy link
Copy Markdown
Contributor Author

TOUFIKIzakarya commented Jan 13, 2026

Hello @DeanArbel,

Sorry for being late, i added the depracated field to yml. And can't see any url_sufix in the python file.

@DeanArbel DeanArbel merged commit 0de6d03 into demisto:contrib/TOUFIKIzakarya_fix/typo_http_command Jan 14, 2026
24 of 25 checks passed
@content-bot content-bot mentioned this pull request Jan 14, 2026
Merged
2 tasks
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 14, 2026

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

DeanArbel pushed a commit that referenced this pull request Jan 18, 2026
@content-bot @TOUFIKIzakarya
Sekoia XDR Pack : Fix small typo (#42514) (#42662)
4d1a774 
* Sekoia XDR Pack : Fix small typo

* feat(conf) : add deprecated to the old param

Co-authored-by: TOUFIKI Zakarya <57439240+TOUFIKIzakarya@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@content-bot content-bot content-bot left review comments

@DeanArbel DeanArbel DeanArbel approved these changes

@merit-maita merit-maita Awaiting requested review from merit-maita

Assignees

@DeanArbel DeanArbel

@merit-maita merit-maita

Labels

Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TOUFIKIzakarya @content-bot @DeanArbel @merit-maita