Sync VHDLTest with TemplateDotNetTool template by Copilot · Pull Request #103 · demaconsulting/VHDLTest

Copilot · 2026-03-06T19:12:13Z

Brings VHDLTest up to date with the current TemplateDotNetTool template patterns. All tests pass across .NET 8, 9, and 10.

Description

Configuration

.editorconfig — LF line endings globally; naming/brace/namespace severity raised to warning; added csharp_nullable_reference_types = enable
.markdownlint-cli2.jsonc — Added MD024: { siblings_only: true } to allow duplicate headings in different document sections; fixed node_modules ignore glob
.cspell.json — ignorePaths aligned to template; fixed *spdx.json → *.spdx.json
.github/dependabot.yml — NuGet group renamed dotnet-dependencies → nuget-dependencies

GitHub Templates & Workflows

ISSUE_TEMPLATE/config.yml — Added 📚 Documentation link; renamed discussions entry
ISSUE_TEMPLATE/question.yml — Added missing question/help template
pull_request_template.md — Added self-validation step; fixed YAML lint command to yamllint .
workflows/build.yaml — Aligned step names/order; added --pdf-variant pdf/a-3u to all Weasyprint steps; fixed SonarMark to use $SONAR_TOKEN with shell: bash; added macos-latest to build, test-ghdl, and test-nvc matrices; used llvm backend for GHDL on macOS and mcode on Windows/Linux; installed NVC via brew install nvc on macOS (in both build and test-nvc jobs) alongside nickg/setup-nvc-ci@v1 for Linux/Windows; updated OS_SHORT sed command to the simpler s/-latest// pattern in all three jobs

Source Files

Converted all 41 C# source and test files from CRLF → LF
Applied dotnet format to add missing braces (csharp_prefer_braces now enforced as warning)

Bug Fixes

GhdlSimulator.cs — Added explicit ghdl -e elaboration step before ghdl -r in Test() to fix GHDL llvm backend on macOS. The llvm backend requires explicit elaboration to produce a binary executable before running; the mcode backend (Linux/Windows) is unaffected as -e is harmless with in-memory elaboration. Variable renamed from elabResults to elaborateResults to satisfy spell checker.
ActiveHdlSimulator.cs — Standardized the output directory name to VHDLTest.out/ActiveHDL across all references in both Compile() and Test(). The directory was previously created as VHDLTest.out/ActiveHdl (PascalCase) while all script content and -do command arguments used VHDLTest.out/ActiveHDL (all-caps), causing failures on case-sensitive filesystems (Linux/macOS). A private const string LibDirPath is now used as the single source of truth for the directory name.
RunProgram.cs — Fixed a potential deadlock: both stdout and stderr are now drained concurrently via ReadToEndAsync() tasks started before WaitForExit(), preventing either pipe's buffer from filling and blocking the child process.
Runner.cs (test helper) — Same deadlock fix applied: async reads of both streams are started before WaitForExit(). Stderr output is now also captured and included in the returned output string instead of being silently discarded.
VivadoSimulator.cs — Fixed stale copy-paste comment: "Run the ModelSim compiler" corrected to "Run the Vivado compiler".

Validation Diagnostics

Validation.cs — When a self-validation test fails, the output now includes the simulator exit code and the full captured simulator log (each line indented), making CI failures easier to diagnose

Documentation

AGENTS.md — Added Agent Selection Guide, Project Structure, CI/CD, Markdown Link Style, and Agent Report Files sections; added macos@TestName source filter; updated CI/CD section to reflect Windows/Linux/macOS build support and GHDL/NVC on Windows/Linux/macOS
requirements.yaml — Added macos@TestName source filter comment; added VHDLTest-Plt-MacOS platform requirement linked to macos@VHDLTest_TestPasses / macos@VHDLTest_TestFails

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
Code quality improvement

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

Code builds successfully: dotnet build --configuration Release
All unit tests pass: dotnet test --configuration Release
Self-validation tests pass:
dotnet run --project src/DEMAConsulting.VHDLTest --configuration Release --framework net10.0
--no-build -- --validate
Code produces zero warnings

Code Quality

Code formatting is correct: dotnet format --verify-no-changes
New code has appropriate XML documentation comments
Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

Spell checker passes: cspell "**/*.{md,cs}"
Markdown linter passes: markdownlint "**/*.md"
YAML linter passes: yamllint .

Testing

Added unit tests for new functionality
Updated existing tests if behavior changed
All tests follow the AAA (Arrange, Act, Assert) pattern
Test coverage is maintained or improved

Documentation

Updated README.md (if applicable)
Updated ARCHITECTURE.md (if applicable)
Added code examples for new features (if applicable)
Updated requirements.yaml (if applicable)

Additional Notes

macOS is added to all three CI job matrices (build, test-ghdl, test-nvc). NVC is installed via brew install nvc on macOS in both the build (unit tests) and test-nvc jobs. GHDL uses the llvm backend on macOS (the mcode backend is not supported on macOS) and mcode on Windows/Linux.

The MD024 markdownlint rule is configured with siblings_only: true to permit duplicate heading text that appears under different parent sections in docs/guide/guide.md (e.g., "Purpose" and "CI/CD Integration" each appear in multiple top-level sections).

The GHDL llvm backend (macOS) requires an explicit elaboration step (ghdl -e) before run (ghdl -r) to produce the binary executable. Without it, ghdl -r fails with "file does not exist / Please elaborate your design". Adding -e before -r fixes macOS and is harmless for the mcode backend on Linux/Windows, where elaboration is in-memory and -r still performs its own elaboration+simulation.

The Active-HDL output directory name inconsistency (VHDLTest.out/ActiveHdl vs VHDLTest.out/ActiveHDL) would cause compile.do and test.do script references to point at a non-existent path on case-sensitive filesystems. A private const string LibDirPath now serves as the single source of truth, and all references consistently use VHDLTest.out/ActiveHDL.

The synchronous ReadToEnd() + ReadToEnd() pattern in RunProgram.Run and the test helper Runner.Run could deadlock if the child process wrote enough output to fill one pipe's buffer while the parent was blocked reading the other. Both are now fixed by starting ReadToEndAsync() tasks for both streams before calling WaitForExit(), which drains both pipes concurrently.

When a self-validation test fails, the exit code and full captured simulator log are now written to the output (indented under the failure headline). This makes it straightforward to diagnose failures in CI.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

- Update .editorconfig to match template format: - Use LF line endings globally (not CRLF for C# files) - Simplified to cleaner template structure - Upgrade naming convention severity from suggestion to warning - Add csharp_nullable_reference_types = enable - Add csharp_prefer_braces = true:warning (was silent) - Add csharp_style_namespace_declarations = file_scoped:warning - Consolidate XML file groups - Convert all C# source and test files from CRLF to LF line endings - Apply dotnet format to fix new csharp_prefer_braces:warning violations - Update .markdownlint-cli2.jsonc: - Remove MD024 (siblings_only) rule not in template - Fix node_modules ignore pattern ('**/node_modules' -> 'node_modules') - Remove comment blocks not in template - Update .cspell.json ignorePaths to match template: - Remove non-template entries: *.csproj, *spdx.json, TestResults, .vs, *.bak - Fix spdx.json pattern to *.spdx.json - Reorder to match template structure - Update .github/ISSUE_TEMPLATE/config.yml: - Add documentation link matching template structure - Update discussions link name from 'Ask a Question' to 'Discussions' - Keep security issue link (VHDLTest-specific) - Add missing .github/ISSUE_TEMPLATE/question.yml (adapted from template) - Update .github/pull_request_template.md: - Add self-validation tests step with VHDLTest project path - Fix YAML linter command to match template (yamllint .) - Update 'All tests pass' to 'All unit tests pass' to match template - Update AGENTS.md: - Add Agent Selection Guide section - Add Project Structure section - Add Documentation section - Add Markdown Link Style section - Add CI/CD section - Add Agent Report Files section - Update Key Files to reference dotnet reqstream --enforce - Update Requirements section to use reqstream enforcement - Update Code Style section with full details - Update .github/agents/requirements-agent.md: - Add Test Source Filters section (matches template) - Update enforcement command to use dotnet reqstream - Update .github/dependabot.yml: - Rename NuGet group from 'dotnet-dependencies' to 'nuget-dependencies' - Update .github/workflows/build.yaml: - Fix quality check step names to match template: 'Spell Check' -> 'Run spell checker' 'Markdown Lint' -> 'Run markdown linter' 'YAML Lint' -> 'Run YAML linter' - Reorder quality checks: markdown first, then spell check, then YAML - Add name field to build job ('Build ${{ matrix.os }}') - Reorder build job: name, needs, permissions (matches template) - Remove inline comments from build job permissions - Add --pdf-variant pdf/a-3u to all Weasyprint PDF generation steps - Fix SonarMark step to use shell:bash and bash-compatible $SONAR_TOKEN

Malcolmnixon · 2026-03-06T19:35:19Z

@copilot These changes do look good, but I suspect some of the changes have not been applied - I'm not seeing the macOS changes, which suggests you failed to review all the template pull requests and analyze them. Please go through the recent pull requests and make sure all appropriate changes have been applied.

…SHORT fix, requirements, AGENTS Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot · 2026-03-06T19:43:33Z

@copilot These changes do look good, but I suspect some of the changes have not been applied - I'm not seeing the macOS changes, which suggests you failed to review all the template...

Applied the missing macOS changes from template PR #54 in commit 4e610d6:

Added macos-latest to the build matrix; nickg/setup-nvc-ci@v1 is now conditional (if: matrix.os != 'macos-latest') since that action doesn't support macOS
Added macos-latest to the test-ghdl matrix with a conditional GHDL backend (llvm on macOS, mcode elsewhere)
Fixed OS_SHORT sed command in all three jobs to use the simpler s/-latest// pattern (produces windows, ubuntu, macos)
Added macos@TestName source filter documentation to requirements.yaml and AGENTS.md
Added VHDLTest-Plt-MacOS platform requirement linked to macos@VHDLTest_TestPasses / macos@VHDLTest_TestFails (evidence comes from GHDL runs on macOS)
NVC test matrix remains Windows/Linux only — nickg/setup-nvc-ci@v1 explicitly throws "Unsupported platform" on macOS

.github/workflows/build.yaml

… to test-nvc matrix Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Malcolmnixon · 2026-03-06T19:54:51Z

@copilot Lint issues - please fix

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot · 2026-03-06T19:57:09Z

@copilot Lint issues - please fix

Fixed in 1b75757. The CI failure was MD024 (duplicate heading) in docs/guide/guide.md — "Purpose" and "CI/CD Integration" appear under different parent sections. Added "MD024": { "siblings_only": true } to .markdownlint-cli2.jsonc to allow duplicate headings that are not siblings of the same parent section. Markdownlint now passes with 0 errors.

Malcolmnixon · 2026-03-06T20:10:53Z

@copilot It does indeed look like mcode doesn't work on macOS - please add back the llvm option for macOS.

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot · 2026-03-06T20:11:59Z

@copilot It does indeed look like mcode doesn't work on macOS - please add back the llvm option for macOS.

Done in 9b22bf5 — the ghdl/setup-ghdl@v1 step now uses backend: ${{ matrix.os == 'macos-latest' && 'llvm' || 'mcode' }}, selecting llvm on macOS and mcode on Windows/Linux.

Malcolmnixon · 2026-03-06T20:24:00Z

@copilot The GHDL tests seem to be failing on macOS:

Run vhdltest --validate --simulator ghdl --results artifacts/ghdl-macos-latest-dotnet10.x-validation.trx && echo "Validation completed successfully"
  vhdltest --validate --simulator ghdl --results artifacts/ghdl-macos-latest-dotnet10.x-validation.trx && echo "Validation completed successfully"
  shell: /opt/homebrew/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    DOTNET_ROOT: /Users/runner/.dotnet
    GHDL_PREFIX: /Users/runner/work/VHDLTest/VHDLTest/install/lib/ghdl
VHDL Test Bench Runner (VHDLTest) 0.0.0-run.291+9b22bf5e1bfbaa79bff7c22a279db4e845b7333e

# DEMAConsulting.VHDLTest

| Information         | Value                                              |
| :------------------ | :------------------------------------------------- |
| VHDLTest Version    | 0.0.0-run.291+9b22bf5e1bfbaa79bff7c22a279db4e845b7333e |
| Machine Name        | sat12-dp146-a57e3b17-400b-457b-81a1-9ac48b1546e1-7E1700F89FF2 |
| OS Version          | macOS 15.7.4                                       |
| DotNet Runtime      | .NET 10.0.3                                        |
| Time Stamp          | 2026-03-06 20:18:53 UTC                            |

Tests:

✗ VHDLTest_TestPasses - Failed
✓ VHDLTest_TestFails - Passed

Total Tests: 2
Passed: 1
Failed: 1

I would like it to pass, but It seems like the failure should probably have more information suggesting what actually failed so it can be fixed.

…failure Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot · 2026-03-06T20:32:40Z

@copilot The GHDL tests seem to be failing on macOS:

Run vhdltest --validate --simulator ghdl --results artifacts/ghdl-macos-latest-dotnet10.x-validation.trx && echo "Validation completed succes...

Done in 1bf9772 — when a validation test fails, the output now includes the simulator exit code and the full captured log, indented under the failure line. This will make it clear exactly what GHDL output/exit code caused VHDLTest_TestPasses to fail on macOS so we can track down the root cause from the CI logs.

Malcolmnixon · 2026-03-06T20:56:25Z

@copilot The GHDL tests are still failing on macOS:

Run vhdltest --validate --simulator ghdl --results artifacts/ghdl-macos-latest-dotnet9.x-validation.trx && echo "Validation completed successfully"
  vhdltest --validate --simulator ghdl --results artifacts/ghdl-macos-latest-dotnet9.x-validation.trx && echo "Validation completed successfully"
  shell: /opt/homebrew/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    DOTNET_ROOT: /Users/runner/.dotnet
    GHDL_PREFIX: /Users/runner/work/VHDLTest/VHDLTest/install/lib/ghdl
VHDL Test Bench Runner (VHDLTest) 0.0.0-run.292+1bf97725bc9ed88b0da87f947ac418bc3f516d5b

# DEMAConsulting.VHDLTest

| Information         | Value                                              |
| :------------------ | :------------------------------------------------- |
| VHDLTest Version    | 0.0.0-run.292+1bf97725bc9ed88b0da87f947ac418bc3f516d5b |
| Machine Name        | iad20-fj923-9694795e-c244-4cdd-884d-78233e188917-0A0DE25F1E3E |
| OS Version          | macOS 15.7.4                                       |
| DotNet Runtime      | .NET 10.0.3                                        |
| Time Stamp          | 2026-03-06 20:54:57 UTC                            |

Tests:

✗ VHDLTest_TestPasses - Failed
  Exit code: 0
  VHDL Test Bench Runner (VHDLTest) 0.0.0-run.292+1bf97725bc9ed88b0da87f947ac418bc3f516d5b
  Building with GHDL...
  Build Passed
  Starting full_adder_pass_tb
  /Users/runner/work/VHDLTest/VHDLTest/install/bin/ghdl:error: file 'full_adder_pass_tb' does not exist
  /Users/runner/work/VHDLTest/VHDLTest/install/bin/ghdl:error: Please elaborate your design.
  Failed full_adder_pass_tb (0.0 seconds)
  Starting full_adder_fail_tb
  /Users/runner/work/VHDLTest/VHDLTest/install/bin/ghdl:error: file 'full_adder_fail_tb' does not exist
  /Users/runner/work/VHDLTest/VHDLTest/install/bin/ghdl:error: Please elaborate your design.
  Failed full_adder_fail_tb (0.0 seconds)
  Starting half_adder_pass_tb
  /Users/runner/work/VHDLTest/VHDLTest/install/bin/ghdl:error: file 'half_adder_pass_tb' does not exist
  /Users/runner/work/VHDLTest/VHDLTest/install/bin/ghdl:error: Please elaborate your design.
  Failed half_adder_pass_tb (0.0 seconds)
  Starting half_adder_fail_tb
  /Users/runner/work/VHDLTest/VHDLTest/install/bin/ghdl:error: file 'half_adder_fail_tb' does not exist
  /Users/runner/work/VHDLTest/VHDLTest/install/bin/ghdl:error: Please elaborate your design.
  Failed half_adder_fail_tb (0.0 seconds)
  ==== summary ===========================
  Failed full_adder_pass_tb (0.0 seconds)
  Failed full_adder_fail_tb (0.0 seconds)
  Failed half_adder_pass_tb (0.0 seconds)
  Failed half_adder_fail_tb (0.0 seconds)
  ========================================
  Failed 4 of 4 tests
✓ VHDLTest_TestFails - Passed

Total Tests: 2
Passed: 1
Failed: 1

… macOS Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot · 2026-03-06T21:02:28Z

@copilot The GHDL tests are still failing on macOS:

Run vhdltest --validate --simulator ghdl --results artifacts/ghdl-macos-latest-dotnet9.x-validation.trx && echo "Validation ...

Fixed in 4584da5 — the root cause was that the llvm backend (used on macOS) requires an explicit ghdl -e elaboration step before ghdl -r, unlike the mcode backend which elaborates implicitly during run.

To answer your question directly: ghdl -e is harmless with mcode. The mcode backend elaborates in-memory and produces no binary, so -e succeeds without side effects, and the subsequent -r still performs its own in-memory elaboration+simulation as normal. The Ubuntu/Windows (mcode) CI jobs confirmed this by passing.

Malcolmnixon · 2026-03-06T21:06:22Z

@copilot Lint issues

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot · 2026-03-06T21:09:08Z

@copilot Lint issues

Fixed in b73cccf — elabResults renamed to elaborateResults so elab no longer triggers the spell checker. All linters pass cleanly now.

Copilot

Pull request overview

This PR synchronizes VHDLTest with the TemplateDotNetTool template by aligning repo configuration, CI workflows, documentation, and code formatting; it also includes a functional fix for GHDL on macOS by adding an explicit elaboration step before running tests.

Changes:

Aligns repo tooling/config/docs with the template (editorconfig, lint/spell configs, GitHub templates, requirements/docs updates).
Updates CI to include macOS in build + simulator test matrices and adjusts GHDL/NVC setup accordingly.
Updates simulator execution flow (notably GHDL -e then -r) and improves validation diagnostics output formatting.

Reviewed changes

Copilot reviewed 29 out of 52 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
test/DEMAConsulting.VHDLTest.Tests/VersionTests.cs	LF conversion / formatting-only updates
test/DEMAConsulting.VHDLTest.Tests/ValidationTests.cs	LF conversion / formatting-only updates
test/DEMAConsulting.VHDLTest.Tests/UsageTests.cs	LF conversion / formatting-only updates
test/DEMAConsulting.VHDLTest.Tests/TestResultsTests.cs	Formatting updates; braces added in cleanup blocks
test/DEMAConsulting.VHDLTest.Tests/TestResultTests.cs	LF conversion / formatting-only updates
test/DEMAConsulting.VHDLTest.Tests/SimulatorFactoryTests.cs	LF conversion / formatting-only updates
test/DEMAConsulting.VHDLTest.Tests/Runner.cs	Braces added; process execution helper touched
test/DEMAConsulting.VHDLTest.Tests/RunProcessorTests.cs	LF conversion / formatting-only updates
test/DEMAConsulting.VHDLTest.Tests/OptionsTests.cs	LF conversion / formatting-only updates
test/DEMAConsulting.VHDLTest.Tests/GlobalUsings.cs	LF conversion / formatting-only updates
test/DEMAConsulting.VHDLTest.Tests/ExitCodeTests.cs	LF conversion / formatting-only updates
test/DEMAConsulting.VHDLTest.Tests/ConfigDocumentTests.cs	LF conversion / formatting-only updates
src/DEMAConsulting.VHDLTest/Simulators/VivadoSimulator.cs	Formatting updates; no behavioral changes intended
src/DEMAConsulting.VHDLTest/Simulators/SimulatorFactory.cs	Formatting updates; no behavioral changes intended
src/DEMAConsulting.VHDLTest/Simulators/Simulator.cs	Formatting updates; no behavioral changes intended
src/DEMAConsulting.VHDLTest/Simulators/QuestaSimSimulator.cs	Formatting updates; no behavioral changes intended
src/DEMAConsulting.VHDLTest/Simulators/NvcSimulator.cs	Formatting updates; no behavioral changes intended
src/DEMAConsulting.VHDLTest/Simulators/ModelSimSimulator.cs	Formatting updates; no behavioral changes intended
src/DEMAConsulting.VHDLTest/Simulators/MockSimulator.cs	Formatting updates; no behavioral changes intended
src/DEMAConsulting.VHDLTest/Simulators/GhdlSimulator.cs	Adds explicit `ghdl -e` elaboration step before `-r`
src/DEMAConsulting.VHDLTest/Simulators/ActiveHdlSimulator.cs	Formatting updates; simulator script/paths touched
src/DEMAConsulting.VHDLTest/Run/RunResults.cs	Formatting-only updates
src/DEMAConsulting.VHDLTest/Run/RunProgram.cs	Formatting updates; process execution helper touched
src/DEMAConsulting.VHDLTest/Run/RunProcessor.cs	Formatting-only updates
src/DEMAConsulting.VHDLTest/Run/RunLineType.cs	Formatting-only updates
src/DEMAConsulting.VHDLTest/Run/RunLineRule.cs	Formatting-only updates
src/DEMAConsulting.VHDLTest/Run/RunLine.cs	Formatting-only updates
src/DEMAConsulting.VHDLTest/Results/TestResults.cs	Formatting updates; SaveResults logic preserved
src/DEMAConsulting.VHDLTest/Results/TestResult.cs	Formatting-only updates
src/DEMAConsulting.VHDLTest/Program.cs	Formatting updates; control flow unchanged
src/DEMAConsulting.VHDLTest/Options.cs	Formatting updates; control flow unchanged
src/DEMAConsulting.VHDLTest/ConfigDocument.cs	Formatting-only updates
requirements.yaml	Adds macOS platform requirement and `macos@...` filter documentation
AGENTS.md	Adds agent guidance, macOS filter notes, and updates enforcement/CI docs
.markdownlint-cli2.jsonc	Adjusts MD024 config and ignore patterns
.github/workflows/build.yaml	Adds macOS to CI matrices; adjusts GHDL backend; installs NVC on macOS; Weasyprint PDF variant + SonarMark token fix
.github/pull_request_template.md	Adds self-validation checklist; updates yamllint command
.github/dependabot.yml	Renames NuGet dependabot group
.github/agents/requirements-agent.md	Updates enforcement command; expands test source filter guidance
.github/ISSUE_TEMPLATE/question.yml	Adds question/help issue template
.github/ISSUE_TEMPLATE/config.yml	Updates contact links (documentation/discussions)
.editorconfig	Enforces LF globally; raises severities; enables nullable reference types
.cspell.json	Aligns ignore paths with template

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/DEMAConsulting.VHDLTest/Simulators/ActiveHdlSimulator.cs

test/DEMAConsulting.VHDLTest.Tests/Runner.cs

src/DEMAConsulting.VHDLTest/Run/RunProgram.cs

src/DEMAConsulting.VHDLTest/Simulators/VivadoSimulator.cs

.github/agents/requirements-agent.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ActiveHDL Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

… fix VivadoSimulator comment Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Initial plan

c5e7825

Copilot AI assigned Copilot and Malcolmnixon Mar 6, 2026

Copilot started work on behalf of Malcolmnixon March 6, 2026 19:12 View session

Copilot AI changed the title ~~[WIP] Update project from template~~ Sync VHDLTest with TemplateDotNetTool template Mar 6, 2026

Copilot finished work on behalf of Malcolmnixon March 6, 2026 19:29

Copilot started work on behalf of Malcolmnixon March 6, 2026 19:35 View session

Add macOS support from template PR #54: build/test-ghdl matrices, OS_…

4e610d6

…SHORT fix, requirements, AGENTS Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot finished work on behalf of Malcolmnixon March 6, 2026 19:44

Malcolmnixon requested changes Mar 6, 2026

View reviewed changes

.github/workflows/build.yaml Show resolved Hide resolved

.github/workflows/build.yaml Show resolved Hide resolved

.github/workflows/build.yaml Show resolved Hide resolved

Copilot started work on behalf of Malcolmnixon March 6, 2026 19:49 View session

Add brew install nvc for macOS, use mcode backend for GHDL, add macOS…

f22bdd3

… to test-nvc matrix Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot finished work on behalf of Malcolmnixon March 6, 2026 19:51

Copilot started work on behalf of Malcolmnixon March 6, 2026 19:54 View session

Fix MD024 lint failure by enabling siblings_only for duplicate headings

1b75757

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot finished work on behalf of Malcolmnixon March 6, 2026 19:58

Copilot started work on behalf of Malcolmnixon March 6, 2026 20:11 View session

Restore llvm backend for GHDL on macOS (mcode unsupported)

9b22bf5

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot finished work on behalf of Malcolmnixon March 6, 2026 20:12

Copilot started work on behalf of Malcolmnixon March 6, 2026 20:24 View session

Add diagnostic output (exit code + simulator log) on validation test …

1bf9772

…failure Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot finished work on behalf of Malcolmnixon March 6, 2026 20:34

Copilot started work on behalf of Malcolmnixon March 6, 2026 20:56 View session

Add GHDL elaboration step (-e) before run (-r) to fix llvm backend on…

4584da5

… macOS Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot finished work on behalf of Malcolmnixon March 6, 2026 21:03

Malcolmnixon marked this pull request as ready for review March 6, 2026 21:03

Copilot AI review requested due to automatic review settings March 6, 2026 21:03

Copilot started reviewing on behalf of Malcolmnixon March 6, 2026 21:04 View session

Copilot started work on behalf of Malcolmnixon March 6, 2026 21:06 View session

Fix cspell: rename elabResults to elaborateResults

b73cccf

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot finished work on behalf of Malcolmnixon March 6, 2026 21:10

Copilot AI reviewed Mar 6, 2026

View reviewed changes

Copilot started work on behalf of Malcolmnixon March 6, 2026 21:17 View session

Malcolmnixon and others added 2 commits March 6, 2026 16:19

Update .github/agents/requirements-agent.md

4162ad5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix ActiveHdlSimulator: standardize output directory to VHDLTest.out/…

0e27b63

…ActiveHDL Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot finished work on behalf of Malcolmnixon March 6, 2026 21:21

Copilot started work on behalf of Malcolmnixon March 6, 2026 21:21 View session

Fix deadlock risks in RunProgram/Runner; add const for ActiveHDL dir;…

fd67f99

… fix VivadoSimulator comment Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

Copilot finished work on behalf of Malcolmnixon March 6, 2026 21:28

Malcolmnixon approved these changes Mar 6, 2026

View reviewed changes

Malcolmnixon merged commit 6debcbd into main Mar 6, 2026
25 of 26 checks passed

Malcolmnixon deleted the copilot/update-project-from-template branch March 6, 2026 21:41

Conversation

Copilot AI commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Configuration

GitHub Templates & Workflows

Source Files

Bug Fixes

Validation Diagnostics

Documentation

Type of Change

Pre-Submission Checklist

Build and Test

Code Quality

Quality Checks

Testing

Documentation

Additional Notes

Uh oh!

Malcolmnixon commented Mar 6, 2026

Uh oh!

Copilot AI commented Mar 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Malcolmnixon commented Mar 6, 2026

Uh oh!

Copilot AI commented Mar 6, 2026

Uh oh!

Malcolmnixon commented Mar 6, 2026

Uh oh!

Copilot AI commented Mar 6, 2026

Uh oh!

Malcolmnixon commented Mar 6, 2026

Uh oh!

Copilot AI commented Mar 6, 2026

Uh oh!

Malcolmnixon commented Mar 6, 2026

Uh oh!

Copilot AI commented Mar 6, 2026

Uh oh!

Malcolmnixon commented Mar 6, 2026

Uh oh!

Copilot AI commented Mar 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 6, 2026 •

edited

Loading