Add fetchpriority prop to YouTube component#226
Add fetchpriority prop to YouTube component#226AoSankaku wants to merge 2 commits intodelucis:mainfrom
Conversation
|
✅ Deploy Preview for astro-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
delucis
left a comment
There was a problem hiding this comment.
Thanks for the PR @AoSankaku. How did you test this? As far as I can tell this PR adds a fetchpriority attribute to the custom element, but this is doesn’t actually do anything?
|
@delucis Thanks for your comment, and actually, as you considered, this doesn't do anything and won't remove LCP request discovery warning in pagespeed insignts. So I added actual prefetch element for better fix. This removes LCP request discovery at least on my website. My personal website uses the exact same patched version of this PR, so you can check it on yourself. This is the result for non-patched version:
This exists. And the patched version is this: "LCP request discovery" warning is gone as you can see. And the diff is here: |

No description provided.