[fix] METEOR GUI: clean-up for z-stack error

[pieleric]

Some missing changes from the review of commit d7b3957 (METEOR GUI: handle better incorrect z-stack parameters). Mainly, declare explicitly the attribute in the __init__().

[coderabbitai]

📝 Walkthrough

Walkthrough

This change enhances error handling for z-stack operations in the CryoAcquiController. A new _zstack_error attribute was introduced to track z-stack validation errors. The _update_acquisition_time method was modified to prevent acquisition and display error messages when z-stack errors exist. The _on_zstack method was updated to set or clear the error state based on operation success or failure, with appropriate state cleanup and timing recalculation.

Possibly related PRs

• [fix] METEOR GUI: handle better incorrect z-stack parameters #3289: Modifies the same CryoAcquiController class to add z-stack error state management and gate acquisition availability based on error presence in similar methods.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: a fix for z-stack error cleanup in METEOR GUI. It's specific and relates directly to the changeset.
Description check	✅ Passed	The PR description directly relates to the changeset, explaining that it adds missing changes to handle z-stack errors by declaring an attribute in init().

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR addresses missing changes from a previous review related to z-stack error handling in the METEOR GUI. The main change explicitly declares the _zstack_error attribute in the __init__() method to ensure proper initialization.

Key Changes:

• Explicitly initialize _zstack_error attribute in the constructor with proper type annotation and documentation
• Add can_acquire variable initialization in the acquisition time update method

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[tepals]

@pieleric what review do these changes relate to?

[pieleric]

@pieleric what review do these changes relate to?

These was comments in the review of PR #3289 (METEOR GUI: handle better incorrect z-stack parameters)