Skip to content

[SWM-202][fix] GUI toolbar incorrect positionning when screen has High DPI scaling #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pieleric merged 1 commit into from
Jan 8, 2026
Merged

[SWM-202][fix] GUI toolbar incorrect positionning when screen has High DPI scaling #3299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions src/odemis/gui/cont/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,26 +238,26 @@ def __init__(self, *args, **kwargs):
self.orientation = kwargs['style'] & (wx.VERTICAL | wx.HORIZONTAL) # mask other bits
if self.orientation == (wx.VERTICAL | wx.HORIZONTAL):
main_sizer = wx.BoxSizer(wx.VERTICAL)
first_bmp = wx.StaticBitmap(self, -1, img.getBitmap("menu/side_menu_bigger_top.png"))
second_bmp = wx.StaticBitmap(self, -1, img.getBitmap("menu/side_menu_bigger_bottom.png"))
first_bmp = img.getBitmap("menu/side_menu_bigger_top.png")
second_bmp = img.getBitmap("menu/side_menu_bigger_bottom.png")
self.btn_sizer = wx.GridBagSizer()
elif self.orientation == wx.VERTICAL:
main_sizer = wx.BoxSizer(wx.VERTICAL)
first_bmp = wx.StaticBitmap(self, -1, img.getBitmap("menu/side_menu_top.png"))
second_bmp = wx.StaticBitmap(self, -1, img.getBitmap("menu/side_menu_bottom.png"))
first_bmp = img.getBitmap("menu/side_menu_top.png")
second_bmp = img.getBitmap("menu/side_menu_bottom.png")
self.btn_sizer = wx.BoxSizer(wx.VERTICAL)
else: # self.orientation == wx.HORIZONTAL:
main_sizer = wx.BoxSizer(wx.HORIZONTAL)
first_bmp = wx.StaticBitmap(self, -1, img.getBitmap("menu/side_menu_left.png"))
second_bmp = wx.StaticBitmap(self, -1, img.getBitmap("menu/side_menu_right.png"))
first_bmp = img.getBitmap("menu/side_menu_left.png")
second_bmp = img.getBitmap("menu/side_menu_right.png")
self.btn_sizer = wx.BoxSizer(wx.HORIZONTAL)

# Set the main sizer that will contain the elements that will form
# the toolbar bar.
self.SetSizer(main_sizer)

# Add the left or top image
main_sizer.Add(first_bmp)
main_sizer.Add(wx.StaticBitmap(self, -1, first_bmp))

# Create a panel that will hold the actual buttons
self.btn_panel = wx.Panel(self, -1)
Expand All @@ -267,12 +267,14 @@ def __init__(self, *args, **kwargs):
# Add the button panel to the toolbar
main_sizer.Add(self.btn_panel)

main_sizer.Add(second_bmp)
main_sizer.Add(wx.StaticBitmap(self, -1, second_bmp))

if self.orientation == (wx.VERTICAL | wx.HORIZONTAL) or self.orientation == wx.VERTICAL:
main_sizer.SetItemMinSize(self.btn_panel, first_bmp.Bitmap.Width, -1)
if self.orientation & wx.VERTICAL:
# Note: using the size on the loaded bitmap means we get it without scaling (in case of High DPI),
# which allows to pass it directly in DIP (display independent pixels).
main_sizer.SetItemMinSize(self.btn_panel, first_bmp.Width, -1)
else:
main_sizer.SetItemMinSize(self.btn_panel, -1, first_bmp.Bitmap.Height)
main_sizer.SetItemMinSize(self.btn_panel, -1, first_bmp.Height)

self._buttons = {}

Expand Down