Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Updates to Preview Branch (dp502/support-scroll) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
WalkthroughThis PR re-enables Scroll in the blockchain options and broadens the related types from a restricted SupportedBlockchain to BlockchainEnum; it also updates the Scroll icon variant and adds Scroll deployments for USDT and ETH to the production token registry. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
07ccd84 to
69c61de
Compare
…o dp502/support-scroll
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/DefuseSDK/constants/blockchains.tsx (1)
186-189: Consider using scroll-white.svg for dark mode to match the pattern of similar chains.Both dark and light modes reference the same icon file. A
scroll-white.svgvariant exists, but unlikexrpledger(which usesxrpledger_white.svgfor dark mode) andgnosis(which usesgnosis_white.svgfor dark mode), the scroll configuration does not leverage this separate variant. If adequate contrast is a concern, consider switching the dark mode icon to/static/icons/network/scroll-white.svg.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/DefuseSDK/constants/blockchains.tsx` around lines 186 - 189, The scroll entry in the blockchains icon constants currently uses the same SVG for both modes; update the dark variant for the scroll object to point to "/static/icons/network/scroll-white.svg" (mirroring how xrpledger and gnosis use their *_white.svg for dark mode) so the scroll dark icon provides proper contrast while leaving the light path as-is.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/components/DefuseSDK/constants/blockchains.tsx`:
- Around line 186-189: The scroll entry in the blockchains icon constants
currently uses the same SVG for both modes; update the dark variant for the
scroll object to point to "/static/icons/network/scroll-white.svg" (mirroring
how xrpledger and gnosis use their *_white.svg for dark mode) so the scroll dark
icon provides proper contrast while leaving the light path as-is.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9047dbbc-c629-4103-b596-a050b2b6bb3a
📒 Files selected for processing (2)
src/components/DefuseSDK/constants/blockchains.tsxsrc/tokens/production.json
🚧 Files skipped from review as they are similar to previous changes (1)
- src/tokens/production.json
No description provided.