Skip to content

feat: add Scroll support#971

Merged
jobotics merged 5 commits intomainfrom
dp502/support-scroll
Mar 16, 2026
Merged

feat: add Scroll support#971
jobotics merged 5 commits intomainfrom
dp502/support-scroll

Conversation

@depressedPlumber502
Copy link
Copy Markdown
Collaborator

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
defuse-widget Ready Ready Preview, Comment Mar 16, 2026 9:14pm

Request Review

@supabase
Copy link
Copy Markdown

supabase Bot commented Mar 4, 2026

Updates to Preview Branch (dp502/support-scroll) ↗︎

Deployments Status Updated
Database Mon, 16 Mar 2026 21:13:50 UTC
Services Mon, 16 Mar 2026 21:13:50 UTC
APIs Mon, 16 Mar 2026 21:13:50 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations Mon, 16 Mar 2026 21:13:51 UTC
Migrations Mon, 16 Mar 2026 21:14:06 UTC
Seeding Mon, 16 Mar 2026 21:14:10 UTC
Edge Functions Mon, 16 Mar 2026 21:14:10 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 4, 2026

Walkthrough

This PR re-enables Scroll in the blockchain options and broadens the related types from a restricted SupportedBlockchain to BlockchainEnum; it also updates the Scroll icon variant and adds Scroll deployments for USDT and ETH to the production token registry.

Changes

Cohort / File(s) Summary
Blockchain configuration
src/components/DefuseSDK/constants/blockchains.tsx
Swapped SupportedBlockchainBlockchainEnum in getBlockchainsOptions and sortBlockchainOptionsByVolume; reinstated the SCROLL option in the blockchains map; changed Scroll dark icon to the standard variant.
Token registry
src/tokens/production.json
Added Scroll deployments for USDT and ETH (hot_omni bridge, Scroll-native addresses) to the production token list under existing grouped tokens entries.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • cawabunga-bytes

Poem

🐰📜 I hopped through code, found Scroll asleep,
I nudged the types and woken it from deep,
New ETH and USDT now romp and play,
Icons polished bright to light the way — hooray! 🎉

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance or clarity of intent. Add a pull request description explaining the changes, such as enabling Scroll blockchain support, the scope of changes, and any testing performed.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title 'feat: add Scroll support' directly and clearly summarizes the main change - enabling Scroll blockchain support by removing workarounds, re-enabling SCROLL entries, and adding asset configurations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dp502/support-scroll
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/components/DefuseSDK/constants/blockchains.tsx (1)

186-189: Consider using scroll-white.svg for dark mode to match the pattern of similar chains.

Both dark and light modes reference the same icon file. A scroll-white.svg variant exists, but unlike xrpledger (which uses xrpledger_white.svg for dark mode) and gnosis (which uses gnosis_white.svg for dark mode), the scroll configuration does not leverage this separate variant. If adequate contrast is a concern, consider switching the dark mode icon to /static/icons/network/scroll-white.svg.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/components/DefuseSDK/constants/blockchains.tsx` around lines 186 - 189,
The scroll entry in the blockchains icon constants currently uses the same SVG
for both modes; update the dark variant for the scroll object to point to
"/static/icons/network/scroll-white.svg" (mirroring how xrpledger and gnosis use
their *_white.svg for dark mode) so the scroll dark icon provides proper
contrast while leaving the light path as-is.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/components/DefuseSDK/constants/blockchains.tsx`:
- Around line 186-189: The scroll entry in the blockchains icon constants
currently uses the same SVG for both modes; update the dark variant for the
scroll object to point to "/static/icons/network/scroll-white.svg" (mirroring
how xrpledger and gnosis use their *_white.svg for dark mode) so the scroll dark
icon provides proper contrast while leaving the light path as-is.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9047dbbc-c629-4103-b596-a050b2b6bb3a

📥 Commits

Reviewing files that changed from the base of the PR and between 1f2dcf3 and 538eef6.

📒 Files selected for processing (2)
  • src/components/DefuseSDK/constants/blockchains.tsx
  • src/tokens/production.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/tokens/production.json

@jobotics jobotics changed the title feat: scroll support feat: add Scroll support Mar 16, 2026
@jobotics jobotics merged commit b79e165 into main Mar 16, 2026
8 checks passed
@jobotics jobotics deleted the dp502/support-scroll branch March 16, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants