Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"author": "defunctzombie",
"dependencies": {
"punycode": "^1.4.1",
"qs": "^6.12.3"
"qs": "^6.14.2"
},
"main": "./url.js",
"keywords": [
Expand Down Expand Up @@ -37,6 +37,6 @@
},
"license": "MIT",
"engines": {
"node": ">= 0.4"
"node": ">= 0.6"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be a breaking change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately without this change I seen failing tests after mentioned update

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which tests? probably best to push it up first and let them fail, so we can all see the issue.

}
}
}