[SP] add SP deny list instead of allow#7887
Open
kashif wants to merge 1 commit intodeepspeedai:masterfrom
Open
[SP] add SP deny list instead of allow#7887kashif wants to merge 1 commit intodeepspeedai:masterfrom
kashif wants to merge 1 commit intodeepspeedai:masterfrom
Conversation
5 tasks
Signed-off-by: Kashif Rasul <kashif.rasul@gmail.com>
tohtana
reviewed
Mar 6, 2026
Collaborator
tohtana
left a comment
There was a problem hiding this comment.
Hi @kashif,
Thank you for opening this PR! I think supporting HF hub kernels is is a significant update.
Regarding the approach, we check if core_attn_implementation is in ALL_ATTENTION_FUNCTIONS but HF hub kernels like kernels-community/flash-attn2 is not in the list. So HF hub kernels won’t still be available with this fix.
We probably need to do the proper registration steps:
- Reject known-bad impls explicitly: eager, flex_attention, and probably paged|eager.
- If
core_attn_implementationis an HF hub kernel string, call the HF registration path first. (Usinglazy_import_flash_attention(…)) - Then read
core_attn_function = ALL_ATTENTION_FUNCTIONS[core_attn_implementation]. - Build
uattnfrom that original function. - Replace that key with
uattn_wrapper.
Does it make sense to you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this way one can register kernels based flash-attn as well with SP