Add document section explaining autocast nesting#7883
Merged
tohtana merged 3 commits intodeepspeedai:masterfrom Mar 4, 2026
Merged
Add document section explaining autocast nesting#7883tohtana merged 3 commits intodeepspeedai:masterfrom
tohtana merged 3 commits intodeepspeedai:masterfrom
Conversation
Explain why users may want to wrap both engine.forward() and loss computation in their own torch.autocast context, and how DeepSpeed handles the resulting nested autocast. Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
The nesting note is better kept only in training.rst. Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
stas00
approved these changes
Mar 4, 2026
Collaborator
stas00
left a comment
stas00
left a comment
There was a problem hiding this comment.
thank you very much - this is great
added a small fix to the text
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a document section clarifying the behavior of nesting autocast and why/when we need it.